Issue 9827004: Ongoing refactoring of chrome/chrome_browser.gypi - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(238)

My Issues | Starred Open | Closed | All

Issue 9827004: Ongoing refactoring of chrome/chrome_browser.gypi (Closed)

Created:
8 years, 9 months ago by Emmanuel Saint-loubert-Bié

Modified:
8 years, 9 months ago

Reviewers:
Elliot Glaysher, Ben Goodger (Google)

CC:
chromium-reviews, Elliot Glaysher

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ongoing refactoring of chrome/chrome_browser.gypi - About 100 lines shorter and several sections consolidated. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128149

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -149 lines)			Patch
	M	chrome/chrome_browser.gypi	View		16 chunks	+52 lines, -149 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Ben: for your review, you might like this erg/FYI the bot linux_aura did not launch ...

8 years, 9 months ago (2012-03-21 22:52:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/9827004/1

8 years, 9 months ago (2012-03-22 01:40:58 UTC) #4

commit-bot: I haz the power

Presubmit check for 9827004-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 9 months ago (2012-03-22 01:41:13 UTC) #5

Presubmit check for 9827004-1 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 43, in
<module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1266, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1114, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1031, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 284, in CheckChangeOnCommit
  File "<string>", line 190, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 912, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 752, in CheckOwners
    approval_needed=input_api.is_committing)
  File "/b/depot_tools/presubmit_canned_checks.py", line 784, in
_RietveldOwnerAndReviewers
    int(input_api.change.issue), True)
  File "/b/depot_tools/rietveld.py", line 92, in get_issue_properties
    return json.loads(self.get(url))
  File "/b/depot_tools/rietveld.py", line 306, in get
    return self._send(request_path, **kwargs)
  File "/b/depot_tools/rietveld.py", line 331, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "/b/depot_tools/third_party/upload.py", line 409, in Send
    ErrorExit(e.read())
  File "/b/depot_tools/rietveld.py", line 323, in trap_http_500
    raise urllib2.HTTPError(request_path, m.group(1), msg, None, None)
urllib2.HTTPError: HTTP Error 500: 
<html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>500 Server Error</title>
</head>
<body text=#000000 bgcolor=#ffffff>
<h1>Error: Server Error</h1>
<h2>The server encountered an error and could not complete your request.<p>If
the problem persists, please <A
HREF="http://code.google.com/appengine/community.html">report</A> your problem
and mention this error message and the query that caused it.</h2>
<h2></h2>
</body></html>

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/9827004/1

8 years, 9 months ago (2012-03-22 01:43:07 UTC) #6

commit-bot: I haz the power

Failed to request the patch to try. Please note that binary filesare still unsupported at ...

8 years, 9 months ago (2012-03-22 01:43:23 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/9827004/1

8 years, 9 months ago (2012-03-22 01:50:16 UTC) #8

Change committed as 128149

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698