Fixing highlight color

chrome/browser/renderer_preferences_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_preferences_util.h"
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/common/renderer_preferences.h"
@@ skipping 18 matching lines @@
   prefs->thumb_inactive_color = theme_service->get_thumb_inactive_color();
   prefs->track_color = theme_service->get_track_color();
   prefs->active_selection_bg_color =
       theme_service->get_active_selection_bg_color();
   prefs->active_selection_fg_color =
       theme_service->get_active_selection_fg_color();
   prefs->inactive_selection_bg_color =
       theme_service->get_inactive_selection_bg_color();
   prefs->inactive_selection_fg_color =
       theme_service->get_inactive_selection_fg_color();
 #else

[Daniel Erat, 2012/03/22 22:56:13]

Mind cleaning this up?  We don't need to support the TOOLKIT_USES_GTK &&
OS_CHROMEOS combination anymore, so this can just be:

#if defined(TOOLKIT_USES_GTK)
  gtk_util::UpdateGtkFontSettings(prefs);
  ThemeServiceGtk* theme_service = ThemeServiceGtk::GetFrom(profile);
  // etc.
#elif defined(OS_CHROMEOS)
  // your new stuff
#endif

  prefs->enable_referrers = ...

It might be the case that we should be using either USE_ASH or USE_AURA rather
than OS_CHROMEOS, too.  Where are the colors that you're trying to match here
defined, NativeThemeAura?

[Ben Goodger (Google), 2012/03/22 23:04:36]

USE_ASH please!

We will match OS_WIN preferences on win+aura.

[Mr4D (OOO till 08-26), 2012/03/22 23:15:53]

Done.

[Mr4D (OOO till 08-26), 2012/03/22 23:15:53]

Sure! I was not sure if GTK is gone for good or might come back after all and as
such I was reluctant to remove entirely. Done.

   prefs->focus_ring_color = SkColorSetRGB(0x50, 0x7A, 0xD5);
   prefs->active_selection_bg_color = SkColorSetRGB(0xDC, 0xE4, 0xFA);
   prefs->active_selection_fg_color = SK_ColorBLACK;
   prefs->inactive_selection_bg_color = SkColorSetRGB(0xEA, 0xEA, 0xEA);
   prefs->inactive_selection_fg_color = SK_ColorBLACK;
 #endif  // defined(OS_CHROMEOS)
 
+#else // defined(TOOLKIT_USES_GTK)
+
+#if defined(OS_CHROMEOS)
+  // This color is 0x544d90fe modulated with 0xffffff.
+  prefs->active_selection_bg_color = SkColorSetRGB(0xCB, 0xE4, 0xFA);
+  prefs->active_selection_fg_color = SK_ColorBLACK;
+  prefs->inactive_selection_bg_color = SkColorSetRGB(0xEA, 0xEA, 0xEA);
+  prefs->inactive_selection_fg_color = SK_ColorBLACK;
+#endif // defined(OS_CHROMEOS)
+
 #endif  // defined(TOOLKIT_USES_GTK)
 
   prefs->enable_referrers =
       profile->GetPrefs()->GetBoolean(prefs::kEnableReferrers);
   prefs->default_zoom_level =
       profile->GetPrefs()->GetDouble(prefs::kDefaultZoomLevel);
 }
 
 }  // renderer_preferences_util