Expose the bluetooth address of the adapter.

Expose the bluetooth address of the adapter.

This is needed for an extension API call:
chrome.experimental.bluetooth.getAddress

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128276

[keybuk, 2012-03-22 17:22:11]

http://codereview.chromium.org/9826018/diff/1/chrome/browser/chromeos/bluetoo...
File chrome/browser/chromeos/bluetooth/bluetooth_adapter.h (right):

http://codereview.chromium.org/9826018/diff/1/chrome/browser/chromeos/bluetoo...
chrome/browser/chromeos/bluetooth/bluetooth_adapter.h:95: std::string address()
const { return address_; }
To avoid copying, make the return type const std::string& ?

[bryeung, 2012-03-22 17:25:08]

http://codereview.chromium.org/9826018/diff/1/chrome/browser/chromeos/bluetoo...
File chrome/browser/chromeos/bluetooth/bluetooth_adapter.h (right):

http://codereview.chromium.org/9826018/diff/1/chrome/browser/chromeos/bluetoo...
chrome/browser/chromeos/bluetooth/bluetooth_adapter.h:95: std::string address()
const { return address_; }
On 2012/03/22 17:22:11, keybuk wrote:
> To avoid copying, make the return type const std::string& ?

Good point: silly mistake on my part.  Fixed.

[keybuk, 2012-03-22 17:30:05]

lgtm, you'll need OWNERS from satorux

[bryeung, 2012-03-22 17:31:09]

satorux@: can you look for OWNERS please?  Thanks.

[satorux1, 2012-03-22 17:35:31]

LGTM, but do you need my LGTM? chrome/browser/chromeos/bluetooth doesn't seem to
have OWNERS.

http://codereview.chromium.org/9826018/diff/3001/chrome/browser/chromeos/blue...
File chrome/browser/chromeos/bluetooth/bluetooth_adapter.h (right):

http://codereview.chromium.org/9826018/diff/3001/chrome/browser/chromeos/blue...
chrome/browser/chromeos/bluetooth/bluetooth_adapter.h:94: // The address of this
adapter.
nit: might want to document how this looks like with an example.

[commit-bot: I haz the power, 2012-03-22 17:39:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/9826018/4003

[commit-bot: I haz the power, 2012-03-22 19:54:33]

Change committed as 128276