Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 9820005: Move PathService's DIR_LAYOUT_TESTS from chrome to content (Closed)

Created:
8 years, 9 months ago by dgrogan
Modified:
8 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, ukai+watch_chromium.org, darin-cc_chromium.org, jsbell
Visibility:
Public.

Description

It can now be used in content without a layering violation. This was discussed in https://chromiumcodereview.appspot.com/9693065/#msg11 BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128155

Patch Set 1 #

Patch Set 2 : remove clang change #

Patch Set 3 : remove indexed_db_uitest changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -113 lines) Patch
M DEPS View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_websocket_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/test/base/layout_test_http_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/test/data/layout_tests/clear_dom_storage.html View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/layout_tests/layout_test_controller.html View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/ui/ui_layout_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_uitest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/common/content_paths.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M content/public/common/content_paths.h View 1 chunk +8 lines, -0 lines 0 comments Download
A + content/test/data/layout_tests/clear_dom_storage.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/layout_tests/layout_test_controller.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrogan
John, could you review this?
8 years, 9 months ago (2012-03-22 01:39:54 UTC) #1
jam
lgtm, thanks
8 years, 9 months ago (2012-03-22 01:48:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9820005/4001
8 years, 9 months ago (2012-03-22 01:52:43 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 03:19:14 UTC) #4
Change committed as 128155

Powered by Google App Engine
This is Rietveld 408576698