Cleanup: Replace 'DurationInt' with int32, and always use 32-bit integers for tracking time.

base/profiler/tracked_time.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PROFILER_TRACKED_TIME_H_
 #define BASE_PROFILER_TRACKED_TIME_H_
 
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/time.h"
 
 namespace tracked_objects {
 
-typedef int DurationInt;
-
 //------------------------------------------------------------------------------
 
-#define USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS

[Ilya Sherman, 2012/03/21 21:47:49]

I should mention: I'm not sure if this #define is still something that you think
is valuable to toggle on and off.  If it is, I'll remove its removal from this
CL.

[jar (doing other things), 2012/03/23 05:28:58]

I don't see us going back... so this is fine to kill.  There was a tiny chance
that we'd make a faster time class (perhaps centered on the message loop...
using TLS there)... but if/when we do... this code will all be gone.

On 2012/03/21 21:47:49, Ilya Sherman wrote:

-
-#if defined(USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS)
-
 // TimeTicks maintains a wasteful 64 bits of data (we need less than 32), and on
 // windows, a 64 bit timer is expensive to even obtain. We use a simple
 // millisecond counter for most of our time values, as well as millisecond units
 // of duration between those values.  This means we can only handle durations
 // up to 49 days (range), or 24 days (non-negative time durations).
 // We only define enough methods to service the needs of the tracking classes,
 // and our interfaces are modeled after what TimeTicks and TimeDelta use (so we
 // can swap them into place if we want to use the "real" classes).
 
 class BASE_EXPORT Duration {  // Similar to base::TimeDelta.
@@ skipping 32 matching lines @@
   static TrackedTime FromMilliseconds(int32 ms) { return TrackedTime(ms); }
 
  private:
   friend class Duration;
   explicit TrackedTime(int32 ms);
 
   // Internal duration is stored directly in milliseconds.
   uint32 ms_;
 };
 
-#else
-
-// Just use full 64 bit time calculations, and the slower TimeTicks::Now().
-// This allows us (as an alternative) to test with larger ranges of times, and
-// with a more thoroughly tested class.
-
-typedef base::TimeTicks TrackedTime;
-typedef base::TimeDelta Duration;
-
-#endif  // USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS
-
 }  // namespace tracked_objects
 
 #endif  // BASE_PROFILER_TRACKED_TIME_H_