Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 9815013: Remove chrome help and feedback pages for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: alpha-sort Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 79be01316f79c48e1d1974e19451f756c87ebc2a..7c3fe432dc5f794c042d8c894d51d2366b8b761f 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -182,16 +182,12 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
return &NewWebUI<ConstrainedHtmlUI>;
if (url.host() == chrome::kChromeUIExtensionsFrameHost)
return &NewWebUI<ExtensionsUI>;
- if (url.host() == chrome::kChromeUIFeedbackHost)
- return &NewWebUI<FeedbackUI>;
if (url.host() == chrome::kChromeUIFlagsHost)
return &NewWebUI<FlagsUI>;
if (url.host() == chrome::kChromeUIFlashHost)
return &NewWebUI<FlashUI>;
if (url.host() == chrome::kChromeUIGpuInternalsHost)
return &NewWebUI<GpuInternalsUI>;
- if (url.host() == chrome::kChromeUIHelpFrameHost)
- return &NewWebUI<HelpUI>;
if (url.host() == chrome::kChromeUIHistoryFrameHost)
return &NewWebUI<HistoryUI>;
if (url.host() == chrome::kChromeUIMediaInternalsHost)
@@ -229,15 +225,17 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
* OS Specific #defines
***************************************************************************/
#if !defined(OS_ANDROID)
- // Android uses the native download manager.
+ // These pages are implemented with native UI elements on Android.
if (url.host() == chrome::kChromeUIDownloadsHost)
return &NewWebUI<DownloadsUI>;
- // Android doesn't use the Options/Options2 pages.
+ if (url.host() == chrome::kChromeUIFeedbackHost)
+ return &NewWebUI<FeedbackUI>;
+ if (url.host() == chrome::kChromeUIHelpFrameHost)
+ return &NewWebUI<HelpUI>;
if (url.host() == chrome::kChromeUISettingsFrameHost)
return &NewWebUI<options2::OptionsUI>;
if (url.host() == chrome::kChromeUISettingsHost)
return &NewWebUI<OptionsUI>;
- // Android doesn't support print/print-preview
if (url.host() == chrome::kChromeUIPrintHost &&
!g_browser_process->local_state()->GetBoolean(
prefs::kPrintPreviewDisabled)) {
« no previous file with comments | « no previous file | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698