Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 9815005: Prerender enabled in incognito. (Closed)

Created:
8 years, 9 months ago by cbentzel
Modified:
8 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Prerender enabled in incognito. This fixes the earlier attempt (http://crrev.com/127763) by increasing the memory allowed for prerendered tabs in the incognito PrerenderManager during tests as well. BUG=108982 TEST=Open in incognito window, go to prerender-test.appspot.com and confirm that prerender works. Also, PrerenderBrowserTest.PrerenderIncognito. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128197

Patch Set 1 #

Patch Set 2 : Increase memory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -28 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 21 chunks +62 lines, -28 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cbentzel
The initial patch is the same as http://codereview.chromium.org/9663005/ The second patch fixes that by increasing ...
8 years, 9 months ago (2012-03-21 14:50:33 UTC) #1
mmenke
On 2012/03/21 14:50:33, cbentzel wrote: > The initial patch is the same as http://codereview.chromium.org/9663005/ > ...
8 years, 9 months ago (2012-03-21 14:57:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9815005/2001
8 years, 9 months ago (2012-03-21 17:25:03 UTC) #3
commit-bot: I haz the power
Try job failure for 9815005-2001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-21 18:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9815005/2001
8 years, 9 months ago (2012-03-22 11:16:22 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 13:04:24 UTC) #6
Change committed as 128197

Powered by Google App Engine
This is Rietveld 408576698