Issue 9814014: Fix remaining link errors in autofill for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9814014: Fix remaining link errors in autofill for Android. (Closed)

Created:
8 years, 9 months ago by Yaron

Modified:
8 years, 9 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, Ilya Sherman, dyu1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix remaining link errors in autofill for Android. BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128146

Patch Set 2 : added comment #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_cc_infobar_delegate.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/autofill/autofill_manager.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

These are due to the fact that there's no Browser/BrowserList on Android.

8 years, 9 months ago (2012-03-21 16:53:28 UTC) #1

Ilya Sherman

LGTM https://chromiumcodereview.appspot.com/9814014/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc File chrome/browser/autofill/autofill_cc_infobar_delegate.cc (right): https://chromiumcodereview.appspot.com/9814014/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc#newcode98 chrome/browser/autofill/autofill_cc_infobar_delegate.cc:98: #endif nit: Please add " // #if defined(OS_ANDROID)" ...

8 years, 9 months ago (2012-03-21 21:50:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9814014/4001

8 years, 9 months ago (2012-03-22 01:46:34 UTC) #3

Change committed as 128146

Expand Messages | Collapse Messages

Issue 9814014: Fix remaining link errors in autofill for Android. (Closed)

Description

Patch Set 1 #

Patch Set 2 : added comment #

Messages