Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 9814013: Ash: Update tab strip for new image assets (Closed)

Created:
8 years, 9 months ago by James Cook
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Ash: Update tab strip for new image assets * Metrics changes for new art. * Allow clicks in the shadow above each tab (4 pixels) to drag the window if the window is restored. This maintains a large click target for dragging. When the window is maximized, let that area select the tab since the window cannot be dragged. * Remove some unused constants. BUG=117431 TEST=Open multiple tabs and check visual appearance for normal window, incognito window, maximized window. Also apply a theme and check again. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128160

Patch Set 1 #

Patch Set 2 : fix off-by-one #

Patch Set 3 : fix toolbar height #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -40 lines) Patch
M chrome/app/theme/theme_resources_2x.grd View 4 chunks +45 lines, -13 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 4 chunks +45 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 5 chunks +28 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Scott, PTAL. The only interesting bit is in browser_non_client_frame_view.cc NonClientHitTest() where I redirect some clicks ...
8 years, 9 months ago (2012-03-21 16:33:21 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-21 17:11:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9814013/14
8 years, 9 months ago (2012-03-21 22:00:44 UTC) #3
commit-bot: I haz the power
Try job failure for 9814013-14 (retry) on win_rel for step "ui_tests". It's a second try, ...
8 years, 9 months ago (2012-03-22 00:42:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9814013/14
8 years, 9 months ago (2012-03-22 02:27:40 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 03:32:11 UTC) #6
Change committed as 128160

Powered by Google App Engine
This is Rietveld 408576698