Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 9814011: Rename enterprise policy proto fields from KIOSK to RETAIL. (Closed)

Created:
8 years, 9 months ago by pastarmovj
Modified:
8 years, 9 months ago
CC:
chromium-reviews, binzhao
Visibility:
Public.

Description

Rename enterprise policy proto fields from KIOSK to RETAIL. R=mnissler@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128226

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Bin's comment. #

Patch Set 3 : Fixed compilation and addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/policy/device_token_fetcher.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/proto/device_management_backend.proto View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/tools/testserver/device_management.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
pastarmovj
Wow I just used the R flag and it added you as a reviewer automagically. ...
8 years, 9 months ago (2012-03-21 15:37:58 UTC) #1
Bin
http://codereview.chromium.org/9814011/diff/1/chrome/browser/policy/proto/chrome_device_policy.proto File chrome/browser/policy/proto/chrome_device_policy.proto (left): http://codereview.chromium.org/9814011/diff/1/chrome/browser/policy/proto/chrome_device_policy.proto#oldcode163 chrome/browser/policy/proto/chrome_device_policy.proto:163: message StartUpUrlsProto { This is newly added setting. I ...
8 years, 9 months ago (2012-03-21 16:17:31 UTC) #2
Mattias Nissler (ping if slow)
Look, it is RETAIL! No, it's a KIOSK! RETAIL! KIOSK! I can see us switching ...
8 years, 9 months ago (2012-03-21 16:35:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9814011/5001
8 years, 9 months ago (2012-03-21 16:59:17 UTC) #4
commit-bot: I haz the power
Try job failure for 9814011-5001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-21 17:21:47 UTC) #5
Mattias Nissler (ping if slow)
LGTM provided you get green tryjobs
8 years, 9 months ago (2012-03-22 10:42:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9814011/8007
8 years, 9 months ago (2012-03-22 11:50:53 UTC) #7
commit-bot: I haz the power
Presubmit check for 9814011-8007 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-22 11:50:57 UTC) #8
pastarmovj
Adding phajdan.jr as the CL needs owner approval for the changes in net/tools/testserver.
8 years, 9 months ago (2012-03-22 12:03:11 UTC) #9
Paweł Hajdan Jr.
testserver LGTM
8 years, 9 months ago (2012-03-22 14:07:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9814011/8007
8 years, 9 months ago (2012-03-22 15:21:16 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 16:35:07 UTC) #12
Change committed as 128226

Powered by Google App Engine
This is Rietveld 408576698