Adjust uber tray spacing around avatar and draw avatar using rounded rectangle.

Adjust uber tray spacing around avatar and draw avatar using rounded rectangle.

BUG=117213
TEST=None.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128138

[flackr, 2012-03-21 21:20:34]

Hi. This reduces the size of the uber tray to spec, and draws the avatar in a
rounded box. The bug has a screenshot. Please take a look. Thanks!

[sadrul, 2012-03-21 21:26:15]

LGTM, with a UI gripe:

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (right):

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/tray/system_...
ash/system/tray/system_tray.cc:410: views::BoxLayout::kHorizontal, 1, 1,
kTrayPaddingBetweenItems));
The lack of horizontal padding on the left looks ... ew!

[Ben Goodger (Google), 2012-03-21 22:10:40]

LGTM with nits

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
File ash/system/user/tray_user.cc (right):

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
ash/system/user/tray_user.cc:274: RoundedImageView(int corner_radius) :
corner_radius_(corner_radius) {
explicit

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
ash/system/user/tray_user.cc:326: };
DISALLOW_COPY

[flackr, 2012-03-21 23:19:05]

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (right):

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/tray/system_...
ash/system/tray/system_tray.cc:410: views::BoxLayout::kHorizontal, 1, 1,
kTrayPaddingBetweenItems));
On 2012/03/21 21:26:15, sadrul wrote:
> The lack of horizontal padding on the left looks ... ew!

Fixed, thanks for the tip.

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
File ash/system/user/tray_user.cc (right):

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
ash/system/user/tray_user.cc:274: RoundedImageView(int corner_radius) :
corner_radius_(corner_radius) {
On 2012/03/21 22:10:41, Ben Goodger (Google) wrote:
> explicit

Done.

https://chromiumcodereview.appspot.com/9813020/diff/1/ash/system/user/tray_us...
ash/system/user/tray_user.cc:326: };
On 2012/03/21 22:10:41, Ben Goodger (Google) wrote:
> DISALLOW_COPY

Done.

[commit-bot: I haz the power, 2012-03-22 00:03:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/9813020/6001

[commit-bot: I haz the power, 2012-03-22 00:03:32]

Can't apply patch for file ash/system/tray/system_tray.cc.
While running patch -p1 --forward --force;
patching file ash/system/tray/system_tray.cc
Hunk #1 succeeded at 258 with fuzz 2 (offset 4 lines).
Hunk #2 FAILED at 407.
1 out of 2 hunks FAILED -- saving rejects to file
ash/system/tray/system_tray.cc.rej

[commit-bot: I haz the power, 2012-03-22 00:26:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/9813020/8003

[commit-bot: I haz the power, 2012-03-22 01:50:08]

Change committed as 128138