aura: Uber tray should not show up on start screen in kiosk mode.

aura: Uber tray should not show up on start screen in kiosk mode.

BUG=119340
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128257

[sadrul, 2012-03-22 04:15:35]

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:140: return
!chromeos::KioskModeHelper::IsKioskModeEnabled();
Does this work correctly if you login (in kiosk mode), and the browser crashes?
(close all browsers, then go to 'Settings and Help' from the tray popup)

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:529:
tray_->UpdateAfterLoginStatusChange(GetUserLoginStatus());
Update visibility in SystemTray::UpdateAfterLoginStatusChange instead?

[varunjain, 2012-03-22 04:19:37]

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:140: return
!chromeos::KioskModeHelper::IsKioskModeEnabled();
On 2012/03/22 04:15:36, sadrul wrote:
> Does this work correctly if you login (in kiosk mode), and the browser
crashes?
> (close all browsers, then go to 'Settings and Help' from the tray popup)

Seems to work.

https://chromiumcodereview.appspot.com/9812043/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:529:
tray_->UpdateAfterLoginStatusChange(GetUserLoginStatus());
On 2012/03/22 04:15:36, sadrul wrote:
> Update visibility in SystemTray::UpdateAfterLoginStatusChange instead?

Done.

[sadrul, 2012-03-22 04:27:38]

LGTM. Thanks

[sky, 2012-03-22 15:52:20]

LGTM

[commit-bot: I haz the power, 2012-03-22 15:54:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/9812043/2002

[commit-bot: I haz the power, 2012-03-22 16:19:21]

Try job failure for 9812043-2002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-03-22 17:23:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/9812043/8004

[commit-bot: I haz the power, 2012-03-22 18:37:51]

Change committed as 128257