Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 9812030: Add support for XP SP3 in the Virtual Print Driver. (Closed)

Created:
8 years, 9 months ago by Albert Bodenhamer
Modified:
8 years, 9 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for XP SP3 in the Virtual Print Driver. Delayload winspool.drv and pull the files we need from fixed locations on XP instead of relying on core drivers. On Vista and later the install flow is unchanged GetCorePrinterDrivers and GetPrinterDriverPackagePath are delayloaded so they don't crash on XP. Needed to modify the CabinetCallback to handle the variable structure of the cabs on the different platforms. Added an OS version check on startup. BUG=112035 TEST=Install on XP SP3 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -22 lines) Patch
M cloud_print/virtual_driver/win/install/setup.cc View 5 chunks +62 lines, -22 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Albert Bodenhamer
8 years, 9 months ago (2012-03-22 00:32:34 UTC) #1
Scott Byer
lgtm
8 years, 9 months ago (2012-03-22 00:59:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/9812030/1
8 years, 9 months ago (2012-03-22 16:09:52 UTC) #3
commit-bot: I haz the power
Change committed as 128253
8 years, 9 months ago (2012-03-22 18:24:06 UTC) #4
PhistucK
On 2012/03/22 18:24:06, I haz the power (commit-bot) wrote: > Change committed as 128253 Note ...
8 years, 9 months ago (2012-03-24 12:08:09 UTC) #5
Albert Bodenhamer
8 years, 9 months ago (2012-03-24 23:53:22 UTC) #6
The virtual printer driver is a separate install.  For now, at least, it
will require SP3.  SP2 might be feasible, but it would require additional
research and complexity that doesn't make sense at the moment.

Patches are welcome. :-)



On Sat, Mar 24, 2012 at 5:08 AM, <phistuck@gmail.com> wrote:

> On 2012/03/22 18:24:06, I haz the power (commit-bot) wrote:
>
>> Change committed as 128253
>>
>
> Note that Chrome is supported on Windows XP SP 2, as well -
> https://support.google.com/**chrome/bin/answer.py?hl=en&**
>
answer=95411&topic=14660&ctx=**topic<https://support.google.com/chrome/bin/answer.py?hl=en&answer=95411&topic=14660&ctx=topic>
>
>
http://codereview.chromium.**org/9812030/<http://codereview.chromium.org/9812...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

Powered by Google App Engine
This is Rietveld 408576698