Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 9812003: Disable sending cookies from the SpellingServiceClient class. (Closed)

Created:
8 years, 9 months ago by Hironori Bono
Modified:
8 years, 9 months ago
Reviewers:
battre
CC:
chromium-reviews
Visibility:
Public.

Description

Disable sending cookies from the SpellingServiceClient class. This change adds a load flag net::LOAD_DO_NOT_SEND_COOKIES to prevent URLFetcher from sending cookies to the Spelling service as suggested in Issue 118957. (This service does not need cookies at all.) BUG=118957 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hironori Bono
Greetings Dominic, Thanks for your suggestions. Even though this change implements your suggested solution, would ...
8 years, 9 months ago (2012-03-21 08:37:42 UTC) #1
battre
LGTM. Thank you. Did you check with the server folks that they don't need cookies ...
8 years, 9 months ago (2012-03-21 08:48:31 UTC) #2
Hironori Bono
Greetings Dominic, Yes, I designed this service as a cookie-free one due to a privacy ...
8 years, 9 months ago (2012-03-21 09:31:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/9812003/1
8 years, 9 months ago (2012-03-22 01:11:03 UTC) #4
commit-bot: I haz the power
Try job failure for 9812003-1 (retry) on win_rel for step "installer_util_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-22 04:00:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/9812003/1
8 years, 9 months ago (2012-03-22 05:10:48 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 06:39:55 UTC) #7
Change committed as 128180

Powered by Google App Engine
This is Rietveld 408576698