Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 9811031: Log in stub user only if not showing login screen. (Closed)

Created:
8 years, 9 months ago by rkc
Modified:
8 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, zel
Visibility:
Public.

Description

Log in stub user only if not showing login screen. On running ChromeOS_Chrome on Linux, we log in a stub user; this is however only necessary if we aren't doing a command line login or showing the login screen to the user. On arbitarily logging in the stub user, Chrome thinks that a user is logged in even if the login screen is showing, causing all sorts of issues. R=nkostylev@chromium.org,pastarmovj@chromium.org BUG=None TEST=Tested on Linux with a regular login using the login manager, a stub-login (default when not using the login manager) and a kiosk-mode login. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rkc
8 years, 9 months ago (2012-03-22 03:44:56 UTC) #1
pastarmovj
lgtm, but please before committing this run try bots at least linux_chromeos,linux,linux_chromeos_clang,cros_x86.
8 years, 9 months ago (2012-03-22 09:26:58 UTC) #2
Nikita (slow)
lgtm May as well remove Zel's short-term fix https://chromiumcodereview.appspot.com/9812039/
8 years, 9 months ago (2012-03-22 11:32:30 UTC) #3
zel
lgtm
8 years, 9 months ago (2012-03-22 15:56:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/9811031/1
8 years, 9 months ago (2012-03-22 16:43:25 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 18:16:39 UTC) #6
Change committed as 128251

Powered by Google App Engine
This is Rietveld 408576698