Issue 981002: Add a special case in Math.round for a SMI result. Also change the implementa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 981002: Add a special case in Math.round for a SMI result. Also change the implementa... (Closed)

Created:
10 years, 9 months ago by Oleg Eterevsky

Modified:
9 years, 5 months ago

Reviewers:
Rico, Vladislav Kaznacheev, Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a special case in Math.round for a SMI result. Also change the implementation for non-SMI case. Committed: http://code.google.com/p/v8/source/detail?r=4146

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+13 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

Drive-by comment: Is it worth doing some of the work in math.js like we do ...

10 years, 9 months ago (2010-03-15 20:07:55 UTC) #2

Erik Corry

http://codereview.chromium.org/981002/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/981002/diff/1/2#newcode5337 src/runtime.cc:5337: return Heap::NumberFromDouble(x); Seems like we could just return args[0] ...

10 years, 9 months ago (2010-03-15 20:11:34 UTC) #3

Rico

10 years, 9 months ago (2010-03-16 06:22:37 UTC) #4

A side note - I already considered making inline versions of these two methods
(floor and round)- if you guys think it is worth it I will do it today/tomorrow.

Expand Messages | Collapse Messages