Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/gdata/gdata_uploader.cc

Issue 9809011: GData save package support with MHTML. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/gdata/gdata_download_observer.cc ('K') | « chrome/browser/chromeos/gdata/gdata_download_observer.cc ('k') | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | chrome/browser/download/save_package_file_picker_chromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_uploader.cc
===================================================================
--- chrome/browser/chromeos/gdata/gdata_uploader.cc (revision 128869)
+++ chrome/browser/chromeos/gdata/gdata_uploader.cc (working copy)
@@ -43,6 +43,11 @@
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(upload_file_info);
DCHECK_EQ(upload_file_info->upload_id, -1);
+ DCHECK(!upload_file_info->file_path.empty());
+ DCHECK_NE(upload_file_info->file_size, 0);
+ DCHECK(!upload_file_info->gdata_path.empty());
+ DCHECK(!upload_file_info->title.empty());
+ DCHECK(!upload_file_info->content_type.empty());
asanka 2012/03/26 16:50:14 For regular downloads, it is possible that we don'
achuithb 2012/03/26 19:51:39 We do need to handle this, but I pulled this file
upload_file_info->upload_id = next_upload_id_++;
// Add upload_file_info to our internal map and take ownership.
« chrome/browser/chromeos/gdata/gdata_download_observer.cc ('K') | « chrome/browser/chromeos/gdata/gdata_download_observer.cc ('k') | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | chrome/browser/download/save_package_file_picker_chromeos.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698