GData save package support with MHTML.

chrome/browser/download/save_package_file_picker.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_
 #define CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_
 #pragma once
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/ui/select_file_dialog.h"
 #include "content/public/browser/download_manager_delegate.h"
 
 class DownloadPrefs;
 
 // Handles showing a dialog to the user to ask for the filename to save a page.

[Randy Smith (Not in Mondays), 2012/03/26 21:08:33]

Could you put a comment here (probably under a TODO(achuith)) indicating that in
the case of the SavePackageFilePickerChromeOS the callback is ignored and the
SavePackageFilePicker does the work of saving the file as well?

[achuithb, 2012/03/26 21:35:54]

Probably shouldn't be doing it here?

 class SavePackageFilePicker : public SelectFileDialog::Listener {
  public:
   SavePackageFilePicker(content::WebContents* web_contents,
                         const FilePath& suggested_path,
                         const FilePath::StringType& default_extension,
                         bool can_save_as_complete,
                         DownloadPrefs* download_prefs,
                         content::SaveFilePathPickedCallback callback);
   virtual ~SavePackageFilePicker();
 
   // Used to disable prompting the user for a directory/filename of the saved
   // web page.  This is available for testing.
   static void SetShouldPromptUser(bool should_prompt);
 
- private:
+ protected:

[Randy Smith (Not in Mondays), 2012/03/26 21:08:33]

We didn't talk about this on VC, but (given Zel's request that we just make
ChromeOS always save MHTML) would doing the interface + 2 impls and getting rid
of the private->protected change make sense?  I don't think you're going to need
to do pass-through semantics on ChromeOs anymore.

[achuithb, 2012/03/26 21:35:54]

That's true, so I'll take a look at doing this next.

   // SelectFileDialog::Listener implementation.
   virtual void FileSelected(const FilePath& path,
                             int index,
                             void* params) OVERRIDE;
   virtual void FileSelectionCanceled(void* params) OVERRIDE;
 
   // Used to look up the renderer process for this request to get the context.
   int render_process_id_;
 
   content::SaveFilePathPickedCallback callback_;
 
   // For managing select file dialogs.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(SavePackageFilePicker);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_