Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 9808105: This fixes the includes in the policy connector so that it won't (Closed)

Created:
8 years, 9 months ago by Greg Spencer (Chromium)
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

This fixes the includes in the policy connector so that it won't include chromeos-specific headers on other platforms. This was causing problems for my try jobs. TBR=mnissler@chromium.org BUG=none TEST=ran trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Greg Spencer (Chromium)
8 years, 9 months ago (2012-03-25 00:10:15 UTC) #1
Greg Spencer (Chromium)
Actually, I'm going to TBR this. It's an extremely trivial change, and it's blocking other ...
8 years, 9 months ago (2012-03-26 04:30:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/9808105/1
8 years, 9 months ago (2012-03-26 04:30:47 UTC) #3
commit-bot: I haz the power
Try job failure for 9808105-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-26 06:43:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/9808105/1
8 years, 9 months ago (2012-03-26 06:44:24 UTC) #5
Mattias Nissler (ping if slow)
LGTM
8 years, 9 months ago (2012-03-26 07:06:07 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 08:26:43 UTC) #7
Change committed as 128875

Powered by Google App Engine
This is Rietveld 408576698