Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: build/common.gypi

Issue 9808065: Add support for Mac OS X 64bit builds with GYP (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Fixed typo in commit message Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7647a7969d42a1e4094f8eb16e0701ba948ae992..eb8e641c436957dbfea09781e32d16fb11c8d5b7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -319,6 +319,16 @@
'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
'-Wnon-virtual-dtor', '-Woverloaded-virtual' ],
}],
+ ['OS=="mac" and target_arch=="ia32"', {
Jakob Kummerow 2012/03/28 16:08:51 Since these definitions (here and below) are indep
+ 'xcode_settings': {
+ 'ARCHS': ['i386']
+ }
+ }],
+ ['OS=="mac" and target_arch=="x64"', {
+ 'xcode_settings': {
+ 'ARCHS': ['x86_64']
+ }
+ }],
],
}, # Debug
'Release': {
@@ -360,6 +370,18 @@
# is specified explicitly.
'GCC_STRICT_ALIASING': 'YES',
},
+ 'conditions': [
+ ['target_arch=="ia32"', {
+ 'xcode_settings': {
+ 'ARCHS': ['i386']
+ }
+ }],
+ ['target_arch=="x64"', {
+ 'xcode_settings': {
+ 'ARCHS': ['x86_64']
+ }
+ }],
+ ],
}], # OS=="mac"
['OS=="win"', {
'msvs_configuration_attributes': {

Powered by Google App Engine
This is Rietveld 408576698