Makefile - Issue 9808065: Add support for Mac OS X 64bit builds with GYP

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Makefile

Issue 9808065: Add support for Mac OS X 64bit builds with GYP (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge

Patch Set: Fixed typo in commit message Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

OLD	NEW
1 # Copyright 2012 the V8 project authors. All rights reserved.	1 # Copyright 2012 the V8 project authors. All rights reserved.

2 # Redistribution and use in source and binary forms, with or without	2 # Redistribution and use in source and binary forms, with or without

3 # modification, are permitted provided that the following conditions are	3 # modification, are permitted provided that the following conditions are

4 # met:	4 # met:

5 #	5 #

6 # * Redistributions of source code must retain the above copyright	6 # * Redistributions of source code must retain the above copyright

7 # notice, this list of conditions and the following disclaimer.	7 # notice, this list of conditions and the following disclaimer.

8 # * Redistributions in binary form must reproduce the above	8 # * Redistributions in binary form must reproduce the above

9 # copyright notice, this list of conditions and the following	9 # copyright notice, this list of conditions and the following

10 # disclaimer in the documentation and/or other materials provided	10 # disclaimer in the documentation and/or other materials provided

(...skipping 248 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
259 then rm $(ENVFILE).new; \	259 then rm $(ENVFILE).new; \

260 else mv $(ENVFILE).new $(ENVFILE); fi	260 else mv $(ENVFILE).new $(ENVFILE); fi

261	261

262 # Stores current GYPFLAGS in a file.	262 # Stores current GYPFLAGS in a file.

263 $(ENVFILE).new:	263 $(ENVFILE).new:

264 @mkdir -p $(OUTDIR); echo "GYPFLAGS=$(GYPFLAGS)" > $(ENVFILE).new;	264 @mkdir -p $(OUTDIR); echo "GYPFLAGS=$(GYPFLAGS)" > $(ENVFILE).new;

265	265

266 # Dependencies.	266 # Dependencies.

267 dependencies:	267 dependencies:

268 svn checkout --force http://gyp.googlecode.com/svn/trunk build/gyp \	268 svn checkout --force http://gyp.googlecode.com/svn/trunk build/gyp \

269 » --revision 1026	269 » --revision 1251
	Jakob Kummerow 2012/03/28 16:08:51 Is there a specific reason you picked revision 125 Is there a specific reason you picked revision 1251? Chromium as of yesterday uses r1282; if it's stable enough for Chromium it should be stable enough for us. fdmanana 2012/03/28 16:49:29 Well, 1026 didn't work, so at the time I picked th Show quoted text On 2012/03/28 16:08:51, Jakob wrote: > Is there a specific reason you picked revision 1251? Chromium as of yesterday > uses r1282; if it's stable enough for Chromium it should be stable enough for > us. Well, 1026 didn't work, so at the time I picked the latest GYP revision that worked, which was 1251. I will update to 1282 if it works as well.
OLD	NEW