Proper support for sequence<T> in IDLs.

Source/WebCore/bindings/dart/DartDOMWrapper.h

 // Copyright 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
@@ skipping 186 matching lines @@
 class LabelableElement;
 Dart_Handle toDartValue(LabelableElement* element);
 
 template<typename T>
 Dart_Handle toDartValue(PassRefPtr< SVGAnimatedEnumerationPropertyTearOff<T> >)
 {
     ASSERT_NOT_REACHED();
     return 0;
 }
 
-template <class Element>
-inline Dart_Handle vectorToDartList(const Vector< RefPtr<Element> >& vector)
+template<typename T>
+Dart_Handle toDartValue(const Vector<T>& vector)
 {
     Dart_Handle list = Dart_NewList(vector.size());
     if (Dart_IsError(list))
         return list;
     for (size_t i = 0; i < vector.size(); i++) {
-        Dart_Handle result = Dart_ListSetAt(list, i, toDartValue(vector[i].get()));
-        if (Dart_IsError(result))
-            return result;
-    }
-    return list;
-}
-
-template <class Element>
-inline Dart_Handle vectorToDartList(const Vector<Element>& vector)
-{
-    // FIXME: create list from vector for primitive types
-    // without element-by-element copying and conversion.
-    // Need VM support.
-    Dart_Handle list = Dart_NewList(vector.size());
-    if (Dart_IsError(list))
-        return list;
-
-    for (size_t i = 0; i < vector.size(); i++) {
         Dart_Handle result = Dart_ListSetAt(list, i, toDartValue(vector[i]));
         if (Dart_IsError(result))
             return result;
     }
     return list;
 }
 
+// FIXME: provide specialization for PassRefPtr as well

[podivilov, 2012/03/23 15:44:12]

We are generating toDartValue(PassRefPtr<T>) to guarantee that toDartValue(T) is
declared before it.

[Anton Muhin, 2012/03/23 17:29:23]

Thanks a lot for bringing this.  I still hope that if we put this into
DartDOMWrapper.h, everything should work smooth.  Am I missing anything?

[podivilov, 2012/03/26 09:45:07]

DartArrayBuffer.h generated header looks like this:

#include "DartDOMWrapper.h"
...
Dart_Handle toDartValue(ArrayBuffer* value)
{
...
}

If toDartValue(PassRefPtr<T>) is defined in DartDOMWrapper.h, it would not
compile because ArrayBuffer is defined in namespace WTF.

+// and do not generate it.
+template<typename T>
+Dart_Handle toDartValue(RefPtr<T> value)
+{
+    return toDartValue(value.get());
+}
+
 template <class Element>
 inline Element toWebGLArrayElement(Dart_Handle, Dart_Handle& exception);
 
 template <>
 inline double toWebGLArrayElement<double>(Dart_Handle object, Dart_Handle& exception)
 {
     return DartUtilities::toDouble(object, exception);
 }
 
 template <>
@@ skipping 529 matching lines @@
 template <>
 class ParameterAdapter<ScriptValue> : public ParameterAdapterBase<ScriptValue> {
 public:
     explicit ParameterAdapter(Dart_Handle handle) { this->unsupported(); }
     operator ScriptValue() const { return this->value(); }
 };
 
 }
 
 #endif // DartDOMWrapper_h