Prepending view-source: does not load the source of the userscript.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 848 matching lines @@
 
   // If this is a stale back/forward (due to a recent navigation the browser
   // didn't know about), ignore it.
   if (IsBackForwardToStaleEntry(params, is_reload))
     return;
 
   // Swap this renderer back in if necessary.
   if (is_swapped_out_)
     SetSwappedOut(false);
 
+  pending_allow_download_ = params.allow_download;
   history_list_offset_ = params.current_history_list_offset;
   history_list_length_ = params.current_history_list_length;
   if (history_list_length_ >= 0)
     history_page_ids_.resize(history_list_length_, -1);
   if (params.pending_history_list_offset >= 0 &&
       params.pending_history_list_offset < history_list_length_)
     history_page_ids_[params.pending_history_list_offset] = params.page_id;
 
   content::GetContentClient()->SetActiveURL(params.url);
 
   WebFrame* main_frame = webview()->mainFrame();
   if (is_reload && main_frame->currentHistoryItem().isNull()) {
     // We cannot reload if we do not have any history state.  This happens, for
     // example, when recovering from a crash.  Our workaround here is a bit of
     // a hack since it means that reload after a crashed tab does not cause an
     // end-to-end cache validation.
     is_reload = false;
   }
 
   pending_navigation_params_.reset(new ViewMsg_Navigate_Params);
   *pending_navigation_params_.get() = params;

[darin (slow to review), 2012/04/03 21:56:20]

it seems like pending_allow_download_ should not be necessary given that
pending_navigation_params_ contains the same information.

[chebert, 2012/04/03 22:13:23]

There is a call to pending_navigation_params_.reset() at the end of this method.
(I originally tried to do it this way.)

 
   // If we are reloading, then WebKit will use the history state of the current
   // page, so we should just ignore any given history state.  Otherwise, if we
   // have history state, then we need to navigate to it, which corresponds to a
   // back/forward navigation event.
   if (is_reload) {
     bool ignore_cache = (params.navigation_type ==
                              ViewMsg_Navigate_Type::RELOAD_IGNORING_CACHE);
     main_frame->reload(ignore_cache);
   } else if (!params.state.empty()) {
@@ skipping 1689 matching lines @@
         document_state->set_load_type(DocumentState::LINK_LOAD_CACHE_ONLY);
         break;
     }
   }
 
   FOR_EACH_OBSERVER(
       RenderViewObserver, observers_, DidCreateDataSource(frame, ds));
 }
 
 void RenderViewImpl::PopulateStateFromPendingNavigationParams(
     DocumentState* document_state) {

[darin (slow to review), 2012/04/03 21:56:20]

here, it seems that you could copy the allow_download flag.

[chebert, 2012/04/03 22:13:23]

Would it be better to put the assignment here than in the OnNavigate() function?

   const ViewMsg_Navigate_Params& params = *pending_navigation_params_.get();
 
   if (document_state->request_time().is_null())
     document_state->set_request_time(params.request_time);
 
   // A navigation resulting from loading a javascript URL should not be treated
   // as a browser initiated event.  Instead, we want it to look as if the page
   // initiated any load resulting from JS execution.
   if (!params.url.SchemeIs(chrome::kJavaScriptScheme)) {
     NavigationState* navigation_state = NavigationState::CreateBrowserInitiated(
@@ skipping 425 matching lines @@
   if (!top_frame)
     top_frame = frame;
   WebDataSource* provisional_data_source = top_frame->provisionalDataSource();
   WebDataSource* top_data_source = top_frame->dataSource();
   WebDataSource* data_source =
       provisional_data_source ? provisional_data_source : top_data_source;
 
   GURL request_url(request.url());
   GURL new_url;
   if (content::GetContentClient()->renderer()->WillSendRequest(
-          frame, request_url, &new_url)) {
+      frame, request_url, &new_url)) {
     request.setURL(WebURL(new_url));
   }
 
   content::PageTransition transition_type = content::PAGE_TRANSITION_LINK;
   DocumentState* document_state = DocumentState::FromDataSource(data_source);
   NavigationState* navigation_state = document_state->navigation_state();
   if (document_state) {
     if (document_state->is_cache_policy_override_set())
       request.setCachePolicy(document_state->cache_policy_override());
     transition_type = navigation_state->transition_type();
   }
 
   request.setExtraData(
       new RequestExtraData(frame->referrerPolicy(),
                            (frame == top_frame),
                            frame->identifier(),
                            frame->parent() == top_frame,
                            frame->parent() ? frame->parent()->identifier() : -1,
+                           pending_allow_download_,
                            transition_type,
                            navigation_state->transferred_request_child_id(),
                            navigation_state->transferred_request_request_id()));
 
   DocumentState* top_document_state =
       DocumentState::FromDataSource(top_data_source);
   // TODO(gavinp): separate out prefetching and prerender field trials
   // if the rel=prerender rel type is sticking around.
   if (top_document_state &&
       (request.targetType() == WebURLRequest::TargetIsPrefetch ||
@@ skipping 2150 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this));
 #endif
 }