Prepending view-source: does not load the source of the userscript.

content/browser/renderer_host/buffered_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/buffered_resource_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/download_stats.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/browser/renderer_host/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/resource_request_info_impl.h"
 #include "content/browser/renderer_host/x509_user_cert_resource_handler.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/resource_dispatcher_host_delegate.h"
 #include "content/public/common/resource_response.h"
+#include "content/public/common/url_constants.h"
 #include "net/base/io_buffer.h"
 #include "net/base/mime_sniffer.h"
 #include "net/base/mime_util.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_content_disposition.h"
 #include "net/http/http_response_headers.h"
 #include "webkit/plugins/webplugininfo.h"
 
 namespace content {
 
@@ skipping 306 matching lines @@
       base::Bind(&BufferedResourceHandler::OnPluginsLoaded, this));
   return true;
 }
 
 // This test mirrors the decision that WebKit makes in
 // WebFrameLoaderClient::dispatchDecidePolicyForMIMEType.
 bool BufferedResourceHandler::ShouldDownload(bool* need_plugin_list) {
   if (need_plugin_list)
     *need_plugin_list = false;
   std::string type = StringToLowerASCII(response_->mime_type);
+  if (request_->virtual_url().SchemeIs(chrome::kViewSourceScheme))

[darin (slow to review), 2012/03/27 03:20:49]

while we can solve this bug by passing around the virtual URL, i'm not so sure
that we want to do that here.  i think it may make more sense to have a flag
that controls whether or not downloading is permitted.

[chebert, 2012/03/31 21:03:18]

Done.

+    return false;
 
   // First, examine Content-Disposition.
   std::string disposition;
   request_->GetResponseHeaderByName("content-disposition", &disposition);
   if (!disposition.empty()) {
     net::HttpContentDisposition parsed_disposition(disposition, std::string());
     if (parsed_disposition.is_attachment())
       return true;
   }
 
   if (host_->delegate() &&
       host_->delegate()->ShouldForceDownloadResource(request_->url(), type))
     return true;
 
   // MIME type checking.
   if (net::IsSupportedMimeType(type))
     return false;
 
   // Finally, check the plugin list.
   bool allow_wildcard = false;
   ResourceRequestInfoImpl* info =

[darin (slow to review), 2012/03/27 03:23:47]

each URLRequest created by the ResourceDispatcherHost has an associated
ResourceRequestInfoImpl.  I would expect to find a flag to allow downloading
here.

[chebert, 2012/03/31 21:03:18]

Done.

       ResourceRequestInfoImpl::ForRequest(request_);
   bool stale = false;
   webkit::WebPluginInfo plugin;
   bool found = PluginServiceImpl::GetInstance()->GetPluginInfo(
       info->GetChildID(), info->GetRouteID(), info->GetContext(),
       request_->url(), GURL(), type, allow_wildcard,
       &stale, &plugin, NULL);
 
   if (need_plugin_list) {
     if (stale) {
@@ skipping 84 matching lines @@
       ResourceRequestInfoImpl::ForRequest(request_);
   int child_id = info->GetChildID();
   int request_id = info->GetRequestID();
 
   host_->PauseRequest(child_id, request_id, false);
   if (!CompleteResponseStarted(request_id))
     host_->CancelRequest(child_id, request_id, false);
 }
 
 }  // namespace content