Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: dbus/object_proxy.cc

Issue 9808001: dbus: don't fail when reconnecting object signals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add docs and unit test Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/object_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/object_proxy.cc
diff --git a/dbus/object_proxy.cc b/dbus/object_proxy.cc
index 0784ea7222a54385877606e0108aeb7f90134d5f..0cbd93e285f61ab9eaae5d19c98f5a00e8a44077 100644
--- a/dbus/object_proxy.cc
+++ b/dbus/object_proxy.cc
@@ -281,14 +281,8 @@ void ObjectProxy::ConnectToSignalInternal(
OnConnectedCallback on_connected_callback) {
bus_->AssertOnDBusThread();
- // Check if the object is already connected to the signal.
const std::string absolute_signal_name =
GetAbsoluteSignalName(interface_name, signal_name);
- if (method_table_.find(absolute_signal_name) != method_table_.end()) {
- LOG(ERROR) << "The object proxy is already connected to "
- << absolute_signal_name;
- return;
- }
// Will become true, if everything is successful.
bool success = false;
« no previous file with comments | « dbus/object_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698