[windows] Make calls to exit(), _exit(), abort(), and ExitProcess() from the renderer process resul…

content/renderer/renderer_main_platform_delegate_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <signal.h>

[brettw, 2012/03/23 21:16:37]

I'd put this after the first header file.

[eroman, 2012/03/23 21:26:23]

Done.

+
 #include "content/renderer/renderer_main_platform_delegate.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/win/win_util.h"
 #include "content/common/injection_test_dll.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/renderer/render_thread.h"
 #include "sandbox/src/sandbox.h"
 #include "skia/ext/skia_sandbox_support_win.h"
 #include "unicode/timezone.h"
 
 namespace {
 
 // In order to have Theme support, we need to connect to the theme service.
@@ skipping 42 matching lines @@
 }
 
 // Windows-only skia sandbox support
 void SkiaPreCacheFont(LOGFONT logfont) {
   content::RenderThread* render_thread = content::RenderThread::Get();
   if (render_thread) {
     render_thread->PreCacheFont(logfont);
   }
 }
 
+void __cdecl ForceCrashOnAbort(int) {

[brettw, 2012/03/23 21:16:37]

Can you call this ...SigAbort or something? At first I was confused why you have
two versions of this function (the other being in base).

[eroman, 2012/03/23 21:26:23]

Done.

+  *((int*)0) = 0x1337;
+}
+
+void InitExitInterceptions() {
+  // If code subsequently tries to exit using exit(), _exit(), abort(), or
+  // ExitProcess(), force a crash (since otherwise these would be silent
+  // terminations and fly under the radar).
+  base::win::SetShouldCrashOnProcessDetach(true);
+
+  // Prevent CRT's abort code from prompting a dialog or trying to "report" it.
+  // Disabling the _CALL_REPORTFAULT behavior is important since otherwise it
+  // has the sideffect of clearing our exception filter, which means we
+  // don't get any crash.
+  _set_abort_behavior(0, _WRITE_ABORT_MSG | _CALL_REPORTFAULT);
+
+  // Set a SIGABRT handler for good measure. We will crash even if the default
+  // is left in place, however this allows us to crash earlier. And it also
+  // lets us crash in response to code which might directly call raise(SIGABRT)
+  signal(SIGABRT, ForceCrashOnAbort);
+}
+
 }  // namespace
 
 RendererMainPlatformDelegate::RendererMainPlatformDelegate(
     const content::MainFunctionParams& parameters)
         : parameters_(parameters),
           sandbox_test_module_(NULL) {
 }
 
 RendererMainPlatformDelegate::~RendererMainPlatformDelegate() {
 }
 
 void RendererMainPlatformDelegate::PlatformInitialize() {
+  InitExitInterceptions();
+
   // Be mindful of what resources you acquire here. They can be used by
   // malicious code if the renderer gets compromised.
   const CommandLine& command_line = parameters_.command_line;
   bool no_sandbox = command_line.HasSwitch(switches::kNoSandbox);
   EnableThemeSupportForRenderer(no_sandbox);
 
   if (!no_sandbox) {
     // ICU DateFormat class (used in base/time_format.cc) needs to get the
     // Olson timezone ID by accessing the registry keys under
     // HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones.
     // After TimeZone::createDefault is called once here, the timezone ID is
     // cached and there's no more need to access the registry. If the sandbox
     // is disabled, we don't have to make this dummy call.
     scoped_ptr<icu::TimeZone> zone(icu::TimeZone::createDefault());
     SetSkiaEnsureTypefaceAccessible(SkiaPreCacheFont);
   }
 }
 
 void RendererMainPlatformDelegate::PlatformUninitialize() {
+  // At this point we are shutting down in a normal code path, so undo our
+  // hack to crash on exit.
+  base::win::SetShouldCrashOnProcessDetach(false);
 }
 
 bool RendererMainPlatformDelegate::InitSandboxTests(bool no_sandbox) {
   const CommandLine& command_line = parameters_.command_line;
 
   DVLOG(1) << "Started renderer with " << command_line.GetCommandLineString();
 
   sandbox::TargetServices* target_services =
       parameters_.sandbox_info->target_services;
 
@@ skipping 36 matching lines @@
                                                           kRenderTestCall));
     DCHECK(run_security_tests);
     if (run_security_tests) {
       int test_count = 0;
       DVLOG(1) << "Running renderer security tests";
       BOOL result = run_security_tests(&test_count);
       CHECK(result) << "Test number " << test_count << " has failed.";
     }
   }
 }