Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 9802037: Pass correct parameters in NaCl proxy for CreateFromIPv[46]Address. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov
Modified:
8 years, 8 months ago
Reviewers:
nfullagar, bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Pass correct parameters in NaCl proxy for CreateFromIPv[46]Address. Previouysly the |ip| parameter wasn't passed properly to the interface implementation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_net_address_private_rpc_server.cc View 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
8 years, 8 months ago (2012-03-28 19:19:57 UTC) #1
nfullagar
lgtm, thx
8 years, 8 months ago (2012-03-28 19:27:53 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-03-28 19:37:06 UTC) #3
bbudge
lgtm
8 years, 8 months ago (2012-03-28 19:48:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9802037/1
8 years, 8 months ago (2012-03-28 19:56:06 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-03-28 22:08:19 UTC) #6
Change committed as 129496

Powered by Google App Engine
This is Rietveld 408576698