Make first_ids_file an optional attribute of the .grd file.

Make first_ids_file an optional attribute of the .grd file.

Remove the default path for resource_ids; the default now is no first
IDs file.  This is part of unbranching grit, since I believe Chrome is
the only project to use a first_ids file.

To resolve landing sequence requirements, this change leaves the
default path in grit_info.py and allows overriding the path via a flag
to grit build, but once a WebKit-side change to WebKit.grd has landed,
both of these can be removed and the only way to specify a first_ids
file will be via each .grd file.

BUG=http://code.google.com/p/grit-i18n/issues/detail?id=4
Committed: https://code.google.com/p/grit-i18n/source/detail?r=19

[Jói, 2012-03-28 14:42:29]

See also http://codereview.chromium.org/9875019/ that adjusts usage of grit in
Chrome to this new default.

I'm hoping to get rid of the command-line flag to set the first_ids file as soon
as I am able to update WebKit to set the file via an attribute, but the commit
order needs to be first grit, then the Chrome DEPS update to pick up grit, then
the WebKit change, then the grit update and Chrome DEPS+grd update to pick up
the version of grit with the command-line flag removed.

Markus, requesting your review of the grit-side change so that I can land it and
send the Chrome-side change to the trybots.  I will ask Tony to take a look at
that one since he is most familiar with it, so he will have final approval
before this impacts Chrome.

Cheers,
Jói

[Jói, 2012-03-28 15:58:10]

Switch reviewer: markusheintz@google.com -> tony@chromium.org

(Markus, please speak up if you already started; I think I probably sent this to
the wrong (@google) address originally, and if Tony is in by now, it's probably
easiest if he reviews both changes).

Cheers,
Jói

[tony, 2012-03-28 17:31:56]

LGTM

http://codereview.chromium.org/9802029/diff/7/grit/node/misc.py
File grit/node/misc.py (right):

http://codereview.chromium.org/9802029/diff/7/grit/node/misc.py#newcode259
grit/node/misc.py:259: else:
Nit: Remove the 'else' and unindent the rest of this method?

http://codereview.chromium.org/9802029/diff/7/grit/tool/build.py
File grit/tool/build.py (right):

http://codereview.chromium.org/9802029/diff/7/grit/tool/build.py#newcode95
grit/tool/build.py:95: # .grd itself.
I like the command line flag. In Chromium, if someone adds a new grd file, I
want it to warn that they need to pick an ID. If grit_action.gypi uses the -f
flag, new .grd files should get this warning automatically.  If we use
attributes, it's easier for someone to forget.

[Jói, 2012-03-29 11:36:15]

Thanks Tony.  Committing with the nit fixed.

Cheers,
Jói

http://codereview.chromium.org/9802029/diff/7/grit/node/misc.py
File grit/node/misc.py (right):

http://codereview.chromium.org/9802029/diff/7/grit/node/misc.py#newcode259
grit/node/misc.py:259: else:
On 2012/03/28 17:31:56, tony wrote:
> Nit: Remove the 'else' and unindent the rest of this method?

Done.

http://codereview.chromium.org/9802029/diff/7/grit/tool/build.py
File grit/tool/build.py (right):

http://codereview.chromium.org/9802029/diff/7/grit/tool/build.py#newcode95
grit/tool/build.py:95: # .grd itself.
On 2012/03/28 17:31:56, tony wrote:
> I like the command line flag. In Chromium, if someone adds a new grd file, I
> want it to warn that they need to pick an ID. If grit_action.gypi uses the -f
> flag, new .grd files should get this warning automatically.  If we use
> attributes, it's easier for someone to forget.

I'd prefer to have just one way to do things, but for now the flag stays and we
can talk before I make further changes.

My plan was to add a presubmit check to Chrome to verify that any .grd file
being modified has the attribute.  What would you say to that approach?  This is
perhaps even more foolproof than the flag, since it would catch somebody adding
a new .grd file that gets built by a customized invocation of grit rather than
using grit_action.gypi.

[tony, 2012-03-29 16:34:48]

On 2012/03/29 11:36:15, Jói wrote:
> On 2012/03/28 17:31:56, tony wrote:
> > I like the command line flag. In Chromium, if someone adds a new grd file, I
> > want it to warn that they need to pick an ID. If grit_action.gypi uses the
-f
> > flag, new .grd files should get this warning automatically.  If we use
> > attributes, it's easier for someone to forget.
> 
> I'd prefer to have just one way to do things, but for now the flag stays and
we
> can talk before I make further changes.
> 
> My plan was to add a presubmit check to Chrome to verify that any .grd file
> being modified has the attribute.  What would you say to that approach?  This
is
> perhaps even more foolproof than the flag, since it would catch somebody
adding
> a new .grd file that gets built by a customized invocation of grit rather than
> using grit_action.gypi.

Ah, a presubmit check would work for me! You're right, that's even better than a
flag.  Ok, let's remove the command line flag!