chrome/test/base/ui_test_utils.cc - Issue 9802025: Rewrite HTML5 workers ui_tests to browser_tests. Compared to ui_tests, browser_tests are faster, le…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 9802025: Rewrite HTML5 workers ui_tests to browser_tests. Compared to ui_tests, browser_tests are faster, le… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: add directory create call needed on linux Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/chrome_tests.gypi ('K') | « chrome/test/base/ui_test_utils.h ('k') | chrome/test/data/workers/many_shared_workers.html » ('j') | chrome/test/data/workers/terminate_queued_workers.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/ui_test_utils.cc

===================================================================

--- chrome/test/base/ui_test_utils.cc (revision 129415)

+++ chrome/test/base/ui_test_utils.cc (working copy)

@@ -435,12 +435,18 @@

content::NOTIFICATION_TAB_ADDED,

content::NotificationService::AllSources());

+ WindowedNotificationObserver auth_observer(

+ chrome::NOTIFICATION_AUTH_NEEDED,

+ content::NotificationService::AllSources());

browser->OpenURL(OpenURLParams(

url, Referrer(), disposition, content::PAGE_TRANSITION_TYPED, false));

if (browser_test_flags & BROWSER_TEST_WAIT_FOR_BROWSER)

browser = WaitForBrowserNotInSet(initial_browsers);

if (browser_test_flags & BROWSER_TEST_WAIT_FOR_TAB)

tab_added_observer.Wait();

+ if (browser_test_flags & BROWSER_TEST_WAIT_FOR_AUTH)

+ auth_observer.Wait();

if (!(browser_test_flags & BROWSER_TEST_WAIT_FOR_NAVIGATION)) {

// Some other flag caused the wait prior to this.

return;