Refactoring copy/paste code.

Refactoring copy/paste code.

Added support for dropping files into list (but not into a folder).

BUG=chromium-os:20162
TEST=Check copy/cut/paste operations. Drag file(s) from one FM page to another.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129418

[dgozman, 2012-03-28 08:28:14]

Please, check that copy/cut/paste related methods in file_manager_pyauto.js do
work.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1095:
clipboard.types.indexOf('fs/iscut') != -1;
This method is not used.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1310:
event.preventDefault();
It would be good to show cursor 'no-drop' otherwise.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:3159: event.returnValue
= !this.canCopyOrDrag_();
Please, add a comment that returnValue==false initiates the copy operation.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/main.html:245: <iframe
id=command-dispatcher hidden></iframe>
I think, init() must be the last item, so js will have access to the whole DOM.

[SeRya, 2012-03-28 08:43:07]

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1095:
clipboard.types.indexOf('fs/iscut') != -1;
On 2012/03/28 08:28:14, dgozman wrote:
> This method is not used.

Done.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:1310:
event.preventDefault();
On 2012/03/28 08:28:14, dgozman wrote:
> It would be good to show cursor 'no-drop' otherwise.

Let's do it later.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:3159: event.returnValue
= !this.canCopyOrDrag_();
On 2012/03/28 08:28:14, dgozman wrote:
> Please, add a comment that returnValue==false initiates the copy operation.

Done.

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/9802024/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/main.html:245: <iframe
id=command-dispatcher hidden></iframe>
On 2012/03/28 08:28:14, dgozman wrote:
> I think, init() must be the last item, so js will have access to the whole
DOM.

Done.

[dgozman, 2012-03-28 08:58:59]

LGTM

[commit-bot: I haz the power, 2012-03-28 12:43:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/9802024/4

[commit-bot: I haz the power, 2012-03-28 15:59:21]

Change committed as 129418