Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 9799001: [Web Intents] Inline installation of extensions in web intents picker. (Closed)

Created:
8 years, 9 months ago by binji
Modified:
8 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Visibility:
Public.

Description

[Web Intents] Inline installation of extensions in web intents picker. Initial CL: http://codereview.chromium.org/9595031/ Second try: http://codereview.chromium.org/9763001/ BUG=113476 TEST=WebIntentsRegistryTest.GetIntentServicesForExtensionFilter, WebIntentPickerControllerBrowserTest.ExtensionInstallSuccess TBR=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128189

Patch Set 1 #

Patch Set 2 : i'm dumb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -94 lines) Patch
M chrome/browser/intents/web_intents_registry.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/intents/web_intents_registry.cc View 4 chunks +74 lines, -13 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 4 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 7 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 11 chunks +121 lines, -20 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 15 chunks +109 lines, -52 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
Really stupid bug... I feel dumb.
8 years, 9 months ago (2012-03-21 01:20:46 UTC) #1
groby-ooo-7-16
LGTM - but care to share what the issue was that made it flaky?
8 years, 9 months ago (2012-03-21 01:24:12 UTC) #2
binji
On 2012/03/21 01:24:12, groby wrote: > LGTM - but care to share what the issue ...
8 years, 9 months ago (2012-03-21 01:47:26 UTC) #3
binji
+rsesek cocoa OWNERS TBR
8 years, 9 months ago (2012-03-21 20:40:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9799001/2001
8 years, 9 months ago (2012-03-21 20:40:21 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 09:46:38 UTC) #6
Change committed as 128189

Powered by Google App Engine
This is Rietveld 408576698