Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 9794008: Added internal intents key to official build (Closed)

Created:
8 years, 9 months ago by groby-ooo-7-16
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Added internal intents key to official build BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128135

Patch Set 1 #

Patch Set 2 : Fixed bad path #

Total comments: 4

Patch Set 3 : Fix sort order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/chrome_browser.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
8 years, 9 months ago (2012-03-21 17:45:23 UTC) #1
sky
http://codereview.chromium.org/9794008/diff/2001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/9794008/diff/2001/chrome/chrome_browser.gypi#newcode1278 chrome/chrome_browser.gypi:1278: 'browser/intents/internal/api_key_internal.cc', sort http://codereview.chromium.org/9794008/diff/2001/chrome/chrome_browser.gypi#newcode4066 chrome/chrome_browser.gypi:4066: 'browser/intents/api_key.cc', Should you also exclude ...
8 years, 9 months ago (2012-03-21 20:44:04 UTC) #2
groby-ooo-7-16
http://codereview.chromium.org/9794008/diff/2001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/9794008/diff/2001/chrome/chrome_browser.gypi#newcode1278 chrome/chrome_browser.gypi:1278: 'browser/intents/internal/api_key_internal.cc', On 2012/03/21 20:44:05, sky wrote: > sort Done. ...
8 years, 9 months ago (2012-03-21 23:32:16 UTC) #3
sky
LGTM
8 years, 9 months ago (2012-03-22 00:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9794008/6001
8 years, 9 months ago (2012-03-22 00:39:42 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 01:40:33 UTC) #6
Commit queue had an internal error.
Something went really wrong, probably a crash, a hickup or
simply the monkeys went out for diner.
The relevant dude was pinged already.

Powered by Google App Engine
This is Rietveld 408576698