Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 9791028: Disable SwiftShader when CPU doesn't have SSE2. (Closed)

Created:
8 years, 9 months ago by jbauman
Modified:
8 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Disable SwiftShader when CPU doesn't have SSE2. Completely disable downloading and running it, as it doesn't work and can pop up an error dialog in this case. BUG=119948 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130049

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbauman
8 years, 9 months ago (2012-03-27 19:32:26 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
8 years, 9 months ago (2012-03-28 22:08:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9791028/1002
8 years, 8 months ago (2012-03-31 07:10:49 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-03-31 09:12:01 UTC) #4
Change committed as 130049

Powered by Google App Engine
This is Rietveld 408576698