Session restore: Add UMA metrics for recording how many tabs were loaded in parallel.

Session restore: Add UMA metrics for recording how many tabs were loaded in parallel.

BUG=NONE
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129411

[marja, 2012-03-27 16:46:52]

Re: discussion about TabLoader & parallel loading of tabs.

sky: ptal.

[sky, 2012-03-27 17:04:33]

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_restore.cc (right):

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_restore.cc:414:
UMA_HISTOGRAM_COUNTS_100("SessionRestore.ParallelTabLoads",
Would it be better to do this in the destructor?

[marja, 2012-03-27 18:37:48]

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_restore.cc (right):

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_restore.cc:414:
UMA_HISTOGRAM_COUNTS_100("SessionRestore.ParallelTabLoads",
On 2012/03/27 17:04:34, sky wrote:
> Would it be better to do this in the destructor?

Hmm, why? The other "finished tab loading" -related metrics are here, too.

[sky, 2012-03-27 20:10:10]

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_restore.cc (right):

http://codereview.chromium.org/9791021/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_restore.cc:414:
UMA_HISTOGRAM_COUNTS_100("SessionRestore.ParallelTabLoads",
On 2012/03/27 18:37:48, marja wrote:
> On 2012/03/27 17:04:34, sky wrote:
> > Would it be better to do this in the destructor?
> 
> Hmm, why? The other "finished tab loading" -related metrics are here, too.

I was assuming you only cared about the max number. Is that not the case?

[sky, 2012-03-27 21:00:54]

LGTM

[commit-bot: I haz the power, 2012-03-28 07:07:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/9791021/1

[commit-bot: I haz the power, 2012-03-28 07:35:55]

Try job failure for 9791021-1 (retry) on linux_rel for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-28 10:41:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/9791021/1

[commit-bot: I haz the power, 2012-03-28 12:32:13]

Try job failure for 9791021-1 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-28 13:10:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/9791021/1

[commit-bot: I haz the power, 2012-03-28 15:06:25]

Change committed as 129411