Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/renderer/extensions/schema_generated_bindings.cc

Issue 9791011: Add experimental.alarms API to allow lazy background pages to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/schema_generated_bindings.cc
diff --git a/chrome/renderer/extensions/schema_generated_bindings.cc b/chrome/renderer/extensions/schema_generated_bindings.cc
index 525c0e8b48e2e9258767cd1ebba9fbd22f411f61..efd1c31657d2ad8644e89056e2bff0562443c9ed 100644
--- a/chrome/renderer/extensions/schema_generated_bindings.cc
+++ b/chrome/renderer/extensions/schema_generated_bindings.cc
@@ -141,7 +141,8 @@ class ExtensionImpl : public ChromeV8Extension {
const std::set<std::string>& function_names =
v8_extension->extension_dispatcher_->function_names();
if (function_names.find(name) == function_names.end()) {
- NOTREACHED() << "Unexpected function " << name;
+ NOTREACHED() << "Unexpected function " << name <<
+ ". Did you remember to register it with ExtensionFunctionRegistry?";
Aaron Boodman 2012/03/28 03:36:18 Heh. Can we automate registration?
Mihai Parparita -not on Chrome 2012/03/28 17:01:31 I thought Mike and Antony's IDL work automates tha
Matt Perry 2012/03/28 20:21:36 Ah, cool, it does. Unfortunately it doesn't quite
return v8::Undefined();
}

Powered by Google App Engine
This is Rietveld 408576698