Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 979005: Re-apply r4159 now with working test on x64 (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re-apply r4159 now with working test on x64 TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -0 lines) Patch
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
A src/circular-queue.h View 1 chunk +130 lines, -0 lines 0 comments Download
A src/circular-queue.cc View 1 chunk +131 lines, -0 lines 0 comments Download
A src/circular-queue-inl.h View 1 chunk +101 lines, -0 lines 0 comments Download
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-circular-queue.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 5 chunks +10 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_arm.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_x64.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 9 months ago (2010-03-17 13:08:40 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-17 13:47:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698