Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 9789002: GYP fix: toolkit_uses_gtk% should be dependent on use_aura%. (Closed)

Created:
8 years, 9 months ago by Elliot Glaysher
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

GYP fix: toolkit_uses_gtk% should be dependent on use_aura%. This fixes the linux_aura FYI builder. This was broken in r127620. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127858

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverse the polarity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
8 years, 9 months ago (2012-03-20 22:19:18 UTC) #1
Emmanuel Saint-loubert-Bié
lgtm https://chromiumcodereview.appspot.com/9789002/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/9789002/diff/1/build/common.gypi#newcode328 build/common.gypi:328: ['OS=="linux" and use_aura==1', { If you want to ...
8 years, 9 months ago (2012-03-20 22:25:14 UTC) #2
Elliot Glaysher
That's a good point. I reversed the polarity.
8 years, 9 months ago (2012-03-20 22:38:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9789002/5001
8 years, 9 months ago (2012-03-20 22:39:02 UTC) #4
commit-bot: I haz the power
Try job failure for 9789002-5001 (retry) (retry) on linux_rel for step "check_deps". It's a second ...
8 years, 9 months ago (2012-03-20 23:59:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9789002/5001
8 years, 9 months ago (2012-03-21 00:01:47 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 01:13:21 UTC) #7
Change committed as 127858

Powered by Google App Engine
This is Rietveld 408576698