Changes to add duration into history database.

chrome/browser/history/history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 #pragma once
 
 #include <string>
 #include <utility>
@@ skipping 117 matching lines @@
   void Closing();
 
   // See NotifyRenderProcessHostDestruction.
   void NotifyRenderProcessHostDestruction(const void* host);
 
   // Navigation ----------------------------------------------------------------
 
   void AddPage(scoped_refptr<HistoryAddPageArgs> request);
   virtual void SetPageTitle(const GURL& url, const string16& title);
   void AddPageNoVisitForBookmark(const GURL& url);
+  void UpdatePageInfo(const void* host,

[GeorgeY, 2012/03/22 00:36:49]

The same problem with comments and const void*
There should be *no* raw pointers going on between the threads: if it is a
meaningful pointer wrap it up into smart_..., if it is an object - use object
instead.
EDIT: I looked at the code and *this* use for const void* is OK, but, please,
comment the same way it is commented elsewhere in the file.

[Wei Li, 2012/03/22 20:05:38]

Done.

+                      int32 page_id,
+                      const GURL& url,
+                      const base::Time end_ts);
+
 
   // Indexing ------------------------------------------------------------------
 
   void SetPageContents(const GURL& url, const string16& contents);
 
   // Querying ------------------------------------------------------------------
 
   // ScheduleAutocomplete() never frees |provider| (which is globally live).
   // It passes |params| on to the autocomplete system which will eventually
   // free it.
@@ skipping 236 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsSource);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsTransitions);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MigrationVisitSource);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MigrationIconMapping);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconMapping);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddOrUpdateIconMapping);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, GetMostRecentVisits);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, GetFaviconForURL);
   FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
                            CloneFaviconIsRestrictedToSameDomain);
-  FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
-                           QueryFilteredURLs);
+  FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, QueryFilteredURLs);
+  FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, UpdateVisitDetails);
 
   friend class ::TestingProfile;
 
   // Computes the name of the specified database on disk.
   FilePath GetThumbnailFileName() const;
 
   // Returns the name of the Favicons database. This is the new name
   // of the Thumbnails database.
   // See ThumbnailDatabase::RenameAndDropThumbnails.
   FilePath GetFaviconsFileName() const;
@@ skipping 22 matching lines @@
   // |cur_visit|. |cur_visit| is assumed to be valid. Assumes that
   // this HistoryBackend object has been Init()ed successfully.
   void GetRedirectsFromSpecificVisit(
       VisitID cur_visit, history::RedirectList* redirects);
 
   // Similar to the above function except returns a redirect list ending
   // at |cur_visit|.
   void GetRedirectsToSpecificVisit(
       VisitID cur_visit, history::RedirectList* redirects);
 
+  // Update the visit details information.
+  void UpdateVisitDetails(VisitID visit_id, const base::Time end_ts);
+
   // Thumbnail Helpers ---------------------------------------------------------
 
   // When a simple GetMostRecentRedirectsFrom() fails, this method is
   // called which searches the last N visit sessions instead of just
   // the current one. Returns true and puts thumbnail data in |data|
   // if a proper thumbnail was found. Returns false otherwise. Assumes
   // that this HistoryBackend object has been Init()ed successfully.
   bool GetThumbnailFromOlderRedirect(
       const GURL& page_url, std::vector<unsigned char>* data);
 
@@ skipping 209 matching lines @@
   // Publishes the history to all indexers which are registered to receive
   // history data from us. Can be NULL if there are no listeners.
   scoped_ptr<HistoryPublisher> history_publisher_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_