Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 9786001: Avoid accessing VarTracker from multiple threads. (Closed)

Created:
8 years, 9 months ago by yzshen1
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Avoid accessing VarTracker from multiple threads. BUG=118223, 118226 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -11 lines) Patch
M ppapi/proxy/plugin_var_tracker.cc View 6 chunks +11 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_var.h View 3 chunks +21 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_var.cc View 7 chunks +40 lines, -8 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 9 chunks +24 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
8 years, 9 months ago (2012-03-20 21:21:40 UTC) #1
brettw
This would explain a lot of those crashes! LGTM
8 years, 9 months ago (2012-03-20 21:31:37 UTC) #2
yzshen1
On 2012/03/20 21:31:37, brettw wrote: > This would explain a lot of those crashes! > ...
8 years, 9 months ago (2012-03-20 21:33:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9786001/1
8 years, 9 months ago (2012-03-20 23:02:06 UTC) #4
commit-bot: I haz the power
Try job failure for 9786001-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-20 23:47:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9786001/1
8 years, 9 months ago (2012-03-21 00:08:46 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 01:35:26 UTC) #7
Change committed as 127871

Powered by Google App Engine
This is Rietveld 408576698