Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 9784014: Static documentation for Font Settings Extension API. (Closed)

Created:
8 years, 9 months ago by falken
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Static documentation for Font Settings Extension API. BUG=114148 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129594

Patch Set 1 #

Total comments: 2

Patch Set 2 : jungshik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
M chrome/common/extensions/docs/experimental.fontSettings.html View 1 2 chunks +64 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/static/experimental.fontSettings.html View 1 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
falken
8 years, 9 months ago (2012-03-28 05:58:53 UTC) #1
falken
+jungshik, in case you have feedback
8 years, 9 months ago (2012-03-28 06:58:26 UTC) #2
Matt Perry
lgtm
8 years, 9 months ago (2012-03-28 18:26:56 UTC) #3
jungshik at Google
LGTM http://codereview.chromium.org/9784014/diff/1/chrome/common/extensions/docs/experimental.fontSettings.html File chrome/common/extensions/docs/experimental.fontSettings.html (right): http://codereview.chromium.org/9784014/diff/1/chrome/common/extensions/docs/experimental.fontSettings.html#newcode293 chrome/common/extensions/docs/experimental.fontSettings.html:293: { genericFamily: 'sansserif', script: 'Hrkt', fontName: 'IPAPGothic' } ...
8 years, 9 months ago (2012-03-28 20:09:45 UTC) #4
falken
http://codereview.chromium.org/9784014/diff/1/chrome/common/extensions/docs/experimental.fontSettings.html File chrome/common/extensions/docs/experimental.fontSettings.html (right): http://codereview.chromium.org/9784014/diff/1/chrome/common/extensions/docs/experimental.fontSettings.html#newcode293 chrome/common/extensions/docs/experimental.fontSettings.html:293: { genericFamily: 'sansserif', script: 'Hrkt', fontName: 'IPAPGothic' } On ...
8 years, 8 months ago (2012-03-29 06:58:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/9784014/5001
8 years, 8 months ago (2012-03-29 06:58:53 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-03-29 08:45:05 UTC) #7
Change committed as 129594

Powered by Google App Engine
This is Rietveld 408576698