Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 9784012: Windows: Don't try to center a popup over a parent window when the popup is bigger than the parent. (Closed)

Created:
8 years, 8 months ago by Lei Zhang
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Windows: Don't try to center a popup over a parent window when the popup is bigger than the parent. BUG=120594 TEST=manual, see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ui/base/win/hwnd_util.cc View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Found more regressions. :(
8 years, 8 months ago (2012-03-28 03:37:27 UTC) #1
Ben Goodger (Google)
LGTM On Tue, Mar 27, 2012 at 8:37 PM, <thestig@chromium.org> wrote: > Reviewers: Ben Goodger ...
8 years, 8 months ago (2012-03-28 16:51:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9784012/1
8 years, 8 months ago (2012-03-28 18:12:25 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-03-28 21:31:09 UTC) #4
Change committed as 129490

Powered by Google App Engine
This is Rietveld 408576698