Refactor tests that performs an action on the password infobar to identify the infobar by type and …

chrome/test/functional/passwords.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 import test_utils
 
 
 class PasswordTest(pyauto.PyUITest):
   """Tests that passwords work correctly."""
 
-  INFOBAR_BUTTON_TEXT = 'Save password'
+  INFOBAR_TYPE = 'password_infobar'
 
   def Debug(self):
     """Test method for experimentation.
 
     This method will not run automatically.
     """
     while True:
       raw_input('Interact with the browser and hit <enter> to dump passwords. ')
       print '*' * 20
       self.pprint(self.GetSavedPasswords())
@@ skipping 47 matching lines @@
       if (element)
         value = element.value;
       window.domAutomationController.send(value);
     """
     self.assertTrue(self.WaitUntil(
         lambda: self.ExecuteJavascript(js_template % 'Email',
                                       tab_index, window_index) != '' and
                 self.ExecuteJavascript(js_template % 'Passwd',
                                       tab_index, window_index) != ''))
 
-  def _InfobarButtonContainsText(self, search_text, windex, tab_index):
-    """Identifies whether an infobar button exists with the specified text.
+  def _InfobarTypeDisplayed(self, infobar_type, windex, tab_index):

[dennis_jeffrey, 2012/03/20 21:17:58]

Change the function name to something like "_GetInfobarIndexByType"

[dyu1, 2012/03/20 22:24:35]

Done.

+    """Identifies whether an infobar displays and get the index.

[dennis_jeffrey, 2012/03/20 21:17:58]

Returns the index of the infobar of the given type.

[dyu1, 2012/03/20 22:24:35]

Done.

 
     Args:
-      search_text: The text to search for on the infobar buttons.
+      infobar_type: The infobar type displayed.
       windex: Window index.
       tab_index: Tab index.
 
     Returns:
-      True, if search_text is found in the buttons, or False otherwise.
+      Index of infobar for infobar type, or -1 if not found.

[dennis_jeffrey, 2012/03/20 21:17:58]

Maybe we should return None in the event it's not found.

[dyu1, 2012/03/20 22:24:35]

Done.

     """
-    infobar = (
+    infobar_list = (
         self.GetBrowserInfo()['windows'][windex]['tabs'][tab_index] \
             ['infobars'])
-    for infobar_info in infobar:
-      if search_text in infobar_info['buttons']:
-        return True
-    return False
+    for infobar in infobar_list:
+      if infobar_type == infobar['type']:
+        return infobar_list.index(infobar)
+    return -1

[dennis_jeffrey, 2012/03/20 21:17:58]

recommend changing '-1' to 'None'

[dyu1, 2012/03/20 22:24:35]

Done.

 
   def _WaitForSavePasswordInfobar(self, windex=0, tab_index=0):
     """Wait for and asserts that the save password infobar appears.
 
     Args:
       windex: Window index. Defaults to 0 (first window).
       tab_index: Tab index. Defaults to 0 (first tab).
+
+    Returns:
+      Index of infobar for infobar type.
     """
     self.assertTrue(
-        self.WaitUntil(lambda: self._InfobarButtonContainsText(
-            self.INFOBAR_BUTTON_TEXT, windex, tab_index)),
+        self.WaitUntil(lambda: self._InfobarTypeDisplayed(
+            self.INFOBAR_TYPE, windex, tab_index) is not -1),

[dennis_jeffrey, 2012/03/20 21:17:58]

we can remove 'is not -1' if you address comment at line 101 above.

[dyu1, 2012/03/20 22:24:35]

Done.

         msg='Save password infobar did not appear.')
+    infobar_index = self._InfobarTypeDisplayed(
+        self.INFOBAR_TYPE, windex, tab_index)
+    return infobar_index

[dennis_jeffrey, 2012/03/20 21:17:58]

combine the above 2 statements into a single statement

[dyu1, 2012/03/20 22:24:35]

Done 

On 2012/03/20 21:17:58, dennis_jeffrey wrote:

 
   def testSavePassword(self):
     """Test saving a password and getting saved passwords."""
     password1 = self._ConstructPasswordDictionary(
         'user@example.com', 'test.password',
         'https://www.example.com/', 'https://www.example.com/login',
         'username', 'password', 'https://www.example.com/login/')
     self.assertTrue(self.AddSavedPassword(password1))
     self.assertEqual(self.GetSavedPasswords(), [password1])
 
@@ skipping 185 matching lines @@
     self.ExecuteJavascript(set_focus, 0, 0)
     self._SendCharToPopulateField('t', tab_index=0, windex=0)
     passwd_value = self.GetDOMValue('document.getElementById("Passwd").value')
     self.assertFalse(passwd_value,
                      msg='Password field not empty for new username.')
     test_utils.ClearPasswords(self)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()