Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 9774001: Remove dependence on .json files for IDL-specified extensions/apps APIs (Closed)

Created:
8 years, 9 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 9 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

Remove dependence on .json files for IDL-specified extensions/apps APIs This is an incremental step towards fully IDL-specified API bindings. This patch adds code which generates JSON based on IDL for the purpose of exposing bindings to javascript. BUG=119137 TEST=Code should compile and existing tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127908

Patch Set 1 #

Patch Set 2 : add trailing newlines in generated files, and ran docs generation (changes are unrelated to my patc… #

Total comments: 9

Patch Set 3 : addessed review comments and removed h_bundle_generator #

Patch Set 4 : resolved conflicts with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -154 lines) Patch
M build/json_schema_bundle_compile.gypi View 3 chunks +6 lines, -10 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/common_resources.grd View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/experimental.dns.json View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/common/extensions/api/extension_api.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 3 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/json_schema_compiler/compiler.py View 1 2 2 chunks +24 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/h_bundle_generator.py View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
A tools/json_schema_compiler/schema_bundle_generator.py View 1 2 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
asargent_no_longer_on_chrome
Ok, ready for review now. Note that I tried to prune what seemed like some ...
8 years, 9 months ago (2012-03-20 21:42:28 UTC) #1
miket_OOO
lgtm http://codereview.chromium.org/9774001/diff/4001/build/json_schema_bundle_compile.gypi File build/json_schema_bundle_compile.gypi (right): http://codereview.chromium.org/9774001/diff/4001/build/json_schema_bundle_compile.gypi#newcode35 build/json_schema_bundle_compile.gypi:35: '<(SHARED_INTERMEDIATE_DIR)/<(cc_dir)/generated_schemas.cc', Nice! http://codereview.chromium.org/9774001/diff/4001/chrome/chrome_common.gypi File chrome/chrome_common.gypi (left): http://codereview.chromium.org/9774001/diff/4001/chrome/chrome_common.gypi#oldcode263 chrome/chrome_common.gypi:263: ...
8 years, 9 months ago (2012-03-20 21:52:16 UTC) #2
asargent_no_longer_on_chrome
New version up that addresses comments. I also realized I had forgotten to remove the ...
8 years, 9 months ago (2012-03-20 23:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/9774001/12001
8 years, 9 months ago (2012-03-20 23:34:50 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/docs/samples.json. While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/samples.json ...
8 years, 9 months ago (2012-03-20 23:35:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/9774001/12002
8 years, 9 months ago (2012-03-20 23:43:03 UTC) #6
commit-bot: I haz the power
Try job failure for 9774001-12002 (retry) on mac_rel for step "check_deps" (clobber build). It's a ...
8 years, 9 months ago (2012-03-21 00:44:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/9774001/12002
8 years, 9 months ago (2012-03-21 04:00:15 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 05:40:19 UTC) #9
Change committed as 127908

Powered by Google App Engine
This is Rietveld 408576698