Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: runtime/lib/byte_array.dart

Issue 9769013: Narrow when storing to a byte array and implement uint64 get and set. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/lib/byte_array.cc ('K') | « runtime/lib/byte_array.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 interface ByteArray extends List default _InternalByteArray { 5 interface ByteArray extends List default _InternalByteArray {
6 ByteArray(int length); 6 ByteArray(int length);
7 7
8 int get length(); 8 int get length();
9 9
10 int getInt8(int byteOffset); 10 int getInt8(int byteOffset);
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 if (length == 0) return []; 160 if (length == 0) return [];
161 Arrays.rangeCheck(this, start, length); 161 Arrays.rangeCheck(this, start, length);
162 ByteArray list = new ByteArray(length); 162 ByteArray list = new ByteArray(length);
163 list._setRange(0, length, this, start); 163 list._setRange(0, length, this, start);
164 return list; 164 return list;
165 } 165 }
166 166
167 167
168 // Implementation 168 // Implementation
169 169
170 int _toInt(int value, int mask) {
171 int result = value & mask;
172 return result > (mask >> 1) ? (result - mask) : result;
173 }
174
175 int _toInt8(int value) {
176 return _toInt(value, (1 << 8) - 1);
177 }
178
179 int _toUint8(int value) {
180 return value & ((1 << 8) - 1);
181 }
182
183 int _toInt16(int value) {
184 return _toInt(value, (1 << 16) - 1);
185 }
186
187 int _toUint16(int value) {
188 return value & ((1 << 16) - 1);
189 }
190
191 int _toInt32(int value) {
192 return _toInt(value, (1 << 32) - 1);
193 }
194
195 int _toUint32(int value) {
196 return value & ((1 << 32) - 1);
197 }
198
199 int _toInt64(int value) {
200 return _toInt(value, (1 << 64) - 1);
201 }
202
203 int _toUint64(int value) {
204 return value & ((1 << 64) - 1);
205 }
206
170 int _length() native "ByteArray_getLength"; 207 int _length() native "ByteArray_getLength";
171 208
172 void _setRange(int start, int length, ByteArray from, int startFrom) 209 void _setRange(int start, int length, ByteArray from, int startFrom)
173 native "ByteArray_setRange"; 210 native "ByteArray_setRange";
174
175 } 211 }
176 212
177 213
178 class _ByteArrayIterator implements Iterator { 214 class _ByteArrayIterator implements Iterator {
179 _ByteArrayIterator(List byteArray) 215 _ByteArrayIterator(List byteArray)
180 : _byteArray = byteArray, _length = byteArray.length, _pos = 0 { 216 : _byteArray = byteArray, _length = byteArray.length, _pos = 0 {
181 assert(byteArray is ByteArray); 217 assert(byteArray is ByteArray);
182 } 218 }
183 219
184 bool hasNext() { 220 bool hasNext() {
(...skipping 20 matching lines...) Expand all
205 return _allocate(length); 241 return _allocate(length);
206 } 242 }
207 243
208 // ByteArray interface 244 // ByteArray interface
209 245
210 int getInt8(int byteOffset) { 246 int getInt8(int byteOffset) {
211 return _getInt8(byteOffset); 247 return _getInt8(byteOffset);
212 } 248 }
213 249
214 void setInt8(int byteOffset, int value) { 250 void setInt8(int byteOffset, int value) {
215 _setInt8(byteOffset, value); 251 _setInt8(byteOffset, _toInt8(value));
216 } 252 }
217 253
218 int getUint8(int byteOffset) { 254 int getUint8(int byteOffset) {
219 return _getUint8(byteOffset); 255 return _getUint8(byteOffset);
220 } 256 }
221 257
222 void setUint8(int byteOffset, int value) { 258 void setUint8(int byteOffset, int value) {
223 _setUint8(byteOffset, value); 259 _setUint8(byteOffset, _toUint8(value));
224 } 260 }
225 261
226 int getInt16(int byteOffset) { 262 int getInt16(int byteOffset) {
227 return _getInt16(byteOffset); 263 return _getInt16(byteOffset);
228 } 264 }
229 265
230 void setInt16(int byteOffset, int value) { 266 void setInt16(int byteOffset, int value) {
231 _setInt16(byteOffset, value); 267 _setInt16(byteOffset, _toInt16(value));
232 } 268 }
233 269
234 int getUint16(int byteOffset) { 270 int getUint16(int byteOffset) {
235 return _getInt16(byteOffset); 271 return _getInt16(byteOffset);
236 } 272 }
237 273
238 void setUint16(int byteOffset, int value) { 274 void setUint16(int byteOffset, int value) {
239 _setUint16(byteOffset, value); 275 _setUint16(byteOffset, _toUint16(value));
240 } 276 }
241 277
242 int getInt32(int byteOffset) { 278 int getInt32(int byteOffset) {
243 return _getInt32(byteOffset); 279 return _getInt32(byteOffset);
244 } 280 }
245 281
246 void setInt32(int byteOffset, int value) { 282 void setInt32(int byteOffset, int value) {
247 _setInt32(byteOffset, value); 283 _setInt32(byteOffset, _toInt32(value));
248 } 284 }
249 285
250 int getUint32(int byteOffset) { 286 int getUint32(int byteOffset) {
251 return _getUint32(byteOffset); 287 return _getUint32(byteOffset);
252 } 288 }
253 289
254 void setUint32(int byteOffset, int value) { 290 void setUint32(int byteOffset, int value) {
255 _setUint32(byteOffset, value); 291 _setUint32(byteOffset, _toUint32(value));
256 } 292 }
257 293
258 int getInt64(int byteOffset) { 294 int getInt64(int byteOffset) {
259 return _getInt64(byteOffset); 295 return _getInt64(byteOffset);
260 } 296 }
261 297
262 void setInt64(int byteOffset, int value) { 298 void setInt64(int byteOffset, int value) {
263 _setInt64(byteOffset, value); 299 _setInt64(byteOffset, _toInt64(value));
264 } 300 }
265 301
266 int getUint64(int byteOffset) { 302 int getUint64(int byteOffset) {
267 return _getUint64(byteOffset); 303 return _getUint64(byteOffset);
268 } 304 }
269 305
270 void setUint64(int byteOffset, int value) { 306 void setUint64(int byteOffset, int value) {
271 _setUint64(byteOffset, value); 307 _setUint64(byteOffset, _toUint64(value));
272 } 308 }
273 309
274 double getFloat32(int byteOffset) { 310 double getFloat32(int byteOffset) {
275 return _getFloat32(byteOffset); 311 return _getFloat32(byteOffset);
276 } 312 }
277 313
278 void setFloat32(int byteOffset, double value) { 314 void setFloat32(int byteOffset, double value) {
279 _setFloat32(byteOffset, value); 315 _setFloat32(byteOffset, value);
280 } 316 }
281 317
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 _setUint8(index, value); 407 _setUint8(index, value);
372 } 408 }
373 409
374 // ByteArray interface 410 // ByteArray interface
375 411
376 int getInt8(int byteOffset) { 412 int getInt8(int byteOffset) {
377 return _getInt8(byteOffset); 413 return _getInt8(byteOffset);
378 } 414 }
379 415
380 void setInt8(int byteOffset, int value) { 416 void setInt8(int byteOffset, int value) {
381 _setInt8(byteOffset, value); 417 _setInt8(byteOffset, _toInt8(value));
382 } 418 }
383 419
384 int getUint8(int byteOffset) { 420 int getUint8(int byteOffset) {
385 return _getUint8(byteOffset); 421 return _getUint8(byteOffset);
386 } 422 }
387 423
388 void setUint8(int byteOffset, int value) { 424 void setUint8(int byteOffset, int value) {
389 _setUint8(byteOffset, value); 425 _setUint8(byteOffset, _toUint8(value));
390 } 426 }
391 427
392 int getInt16(int byteOffset) { 428 int getInt16(int byteOffset) {
393 return _getInt16(byteOffset); 429 return _getInt16(byteOffset);
394 } 430 }
395 431
396 void setInt16(int byteOffset, int value) { 432 void setInt16(int byteOffset, int value) {
397 _setInt16(byteOffset, value); 433 _setInt16(byteOffset, _toInt16(value));
398 } 434 }
399 435
400 int getUint16(int byteOffset) { 436 int getUint16(int byteOffset) {
401 return _getInt16(byteOffset); 437 return _getInt16(byteOffset);
402 } 438 }
403 439
404 void setUint16(int byteOffset, int value) { 440 void setUint16(int byteOffset, int value) {
405 _setUint16(byteOffset, value); 441 _setUint16(byteOffset, _toUint16(value));
406 } 442 }
407 443
408 int getInt32(int byteOffset) { 444 int getInt32(int byteOffset) {
409 return _getInt32(byteOffset); 445 return _getInt32(byteOffset);
410 } 446 }
411 447
412 void setInt32(int byteOffset, int value) { 448 void setInt32(int byteOffset, int value) {
413 _setInt32(byteOffset, value); 449 _setInt32(byteOffset, _toInt32(value));
414 } 450 }
415 451
416 int getUint32(int byteOffset) { 452 int getUint32(int byteOffset) {
417 return _getUint32(byteOffset); 453 return _getUint32(byteOffset);
418 } 454 }
419 455
420 void setUint32(int byteOffset, int value) { 456 void setUint32(int byteOffset, int value) {
421 _setUint32(byteOffset, value); 457 _setUint32(byteOffset, _toUint32(value));
422 } 458 }
423 459
424 int getInt64(int byteOffset) { 460 int getInt64(int byteOffset) {
425 return _getInt64(byteOffset); 461 return _getInt64(byteOffset);
426 } 462 }
427 463
428 void setInt64(int byteOffset, int value) { 464 void setInt64(int byteOffset, int value) {
429 _setInt64(byteOffset, value); 465 _setInt64(byteOffset, _toInt64(value));
430 } 466 }
431 467
432 int getUint64(int byteOffset) { 468 int getUint64(int byteOffset) {
433 return _getUint64(byteOffset); 469 return _getUint64(byteOffset);
434 } 470 }
435 471
436 void setUint64(int byteOffset, int value) { 472 void setUint64(int byteOffset, int value) {
437 _setUint64(byteOffset, value); 473 _setUint64(byteOffset, _toUint64(value));
438 } 474 }
439 475
440 double getFloat32(int byteOffset) { 476 double getFloat32(int byteOffset) {
441 return _getFloat32(byteOffset); 477 return _getFloat32(byteOffset);
442 } 478 }
443 479
444 void setFloat32(int byteOffset, double value) { 480 void setFloat32(int byteOffset, double value) {
445 _setFloat32(byteOffset, value); 481 _setFloat32(byteOffset, value);
446 } 482 }
447 483
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 544
509 void _setFloat32(int byteOffset, double value) 545 void _setFloat32(int byteOffset, double value)
510 native "ExternalByteArray_setFloat32"; 546 native "ExternalByteArray_setFloat32";
511 547
512 double _getFloat64(int byteOffset) 548 double _getFloat64(int byteOffset)
513 native "ExternalByteArray_getFloat64"; 549 native "ExternalByteArray_getFloat64";
514 550
515 void _setFloat64(int byteOffset, double value) 551 void _setFloat64(int byteOffset, double value)
516 native "ExternalByteArray_setFloat64"; 552 native "ExternalByteArray_setFloat64";
517 } 553 }
OLDNEW
« runtime/lib/byte_array.cc ('K') | « runtime/lib/byte_array.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698