Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 9769011: Histogram times surrounding render crashes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | content/public/browser/render_process_host.h » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_process_host_impl.cc (revision 127735)
+++ content/browser/renderer_host/render_process_host_impl.cc (working copy)
@@ -1224,6 +1224,13 @@
// already handled the error.
RendererClosedDetails details(handle, status, exit_code, was_alive);
+
+#if defined(OS_WIN)
+ // We must record data from handle before notifications, which can close the
+ // handle.
+ details.RecordProcessStats();
+#endif // OS_WIN
+
content::NotificationService::current()->Notify(
content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
content::Source<RenderProcessHost>(this),
« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | content/public/browser/render_process_host.h » ('j') | content/public/browser/render_process_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698