Histogram times surrounding render crashes

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/id_map.h"
 #include "base/process.h"
@@ skipping 31 matching lines @@
   struct RendererClosedDetails {
     RendererClosedDetails(base::ProcessHandle handle,
                           base::TerminationStatus status,
                           int exit_code,
                           bool was_alive) {
       this->handle = handle;
       this->status = status;
       this->exit_code = exit_code;
       this->was_alive = was_alive;
     }
+
+#if defined(OS_WIN)
+    void RecordProcessStats() {
+      have_process_times = false;
+      FILETIME win_creation_time;
+      FILETIME win_exit_time;
+      FILETIME win_kernel_time;
+      FILETIME win_user_time;
+      if (0 == GetProcessTimes(handle, &win_creation_time, &win_exit_time,
+                               &win_kernel_time, &win_user_time)) {
+        DWORD error = GetLastError();
+        DLOG(ERROR) << "Error getting process data" << error;
+      }
+      user_duration = base::Time::FromFileTime(win_user_time) -
+          base::Time::Time();
+      kernel_duration = base::Time::FromFileTime(win_kernel_time) -
+          base::Time::Time();
+      run_duration = base::Time::FromFileTime(win_exit_time) -
+          base::Time::FromFileTime(win_creation_time);
+      have_process_times = true;

[rvargas (doing something else), 2012/03/22 01:59:32]

We should not set this flag to true (or read the times) if GetProcessTimes
fails.

[jar (doing other things), 2012/03/22 02:06:44]

<doh!>  I left out my planned early return.

Added now.

+    }
+
+    base::TimeDelta kernel_duration;
+    base::TimeDelta user_duration;
+    base::TimeDelta run_duration;
+    bool have_process_times;
+#endif   // OS_WIN
+
     base::ProcessHandle handle;
     base::TerminationStatus status;
     int exit_code;
     bool was_alive;
   };
 
   virtual ~RenderProcessHost() {}
 
   // Initialize the new renderer process, returning true on success. This must
   // be called once before the object can be used, but can be called after
@@ skipping 174 matching lines @@
 
   // Returns the current max number of renderer processes used by the content
   // module.
   static size_t GetMaxRendererProcessCount();
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_