Histogram times surrounding render crashes

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It
@@ skipping 541 matching lines @@
       LogLoadStarted();
       break;
 
     case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: {
         content::RenderProcessHost::RendererClosedDetails* process_details =
             content::Details<
                 content::RenderProcessHost::RendererClosedDetails>(
                     details).ptr();
         content::RenderProcessHost* host =
             content::Source<content::RenderProcessHost>(source).ptr();
-        LogRendererCrash(
-            host, process_details->status, process_details->was_alive);
+        LogRendererCrash(host, *process_details);
       }
       break;
 
     case content::NOTIFICATION_RENDERER_PROCESS_HANG:
       LogRendererHang();
       break;
 
     case content::NOTIFICATION_CHILD_PROCESS_HOST_CONNECTED:
     case content::NOTIFICATION_CHILD_PROCESS_CRASHED:
     case content::NOTIFICATION_CHILD_INSTANCE_CREATED:
@@ skipping 787 matching lines @@
 }
 
 void MetricsService::LogLoadStarted() {
   HISTOGRAM_ENUMERATION("Chrome.UmaPageloadCounter", 1, 2);
   IncrementPrefValue(prefs::kStabilityPageLoadCount);
   IncrementLongPrefsValue(prefs::kUninstallMetricsPageLoadCount);
   // We need to save the prefs, as page load count is a critical stat, and it
   // might be lost due to a crash :-(.
 }
 
 void MetricsService::LogRendererCrash(content::RenderProcessHost* host,

[rvargas (doing something else), 2012/03/22 01:59:32]

same here

[jar (doing other things), 2012/03/22 02:06:44]

Done.

-                                      base::TerminationStatus status,
-                                      bool was_alive) {
+    const content::RenderProcessHost::RendererClosedDetails& details) {
   Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
   ExtensionService* service = profile->GetExtensionService();
   bool was_extension_process =
       service && service->process_map()->Contains(host->GetID());
-  if (status == base::TERMINATION_STATUS_PROCESS_CRASHED ||
-      status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
-    if (was_extension_process)
+  if (details.status == base::TERMINATION_STATUS_PROCESS_CRASHED ||
+      details.status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
+    if (was_extension_process) {
       IncrementPrefValue(prefs::kStabilityExtensionRendererCrashCount);
-    else
+    } else {
       IncrementPrefValue(prefs::kStabilityRendererCrashCount);
 
+#if defined(OS_WIN)
+      if (details.have_process_times) {
+        if (details.status == base::TERMINATION_STATUS_PROCESS_CRASHED) {
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.CrashedDuration",
+                              details.run_duration);
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.CrashedKernelTime",
+                              details.kernel_duration);
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.CrashedUserTime",
+                              details.user_duration);
+        } else {
+          DCHECK(details.status ==
+                 base::TERMINATION_STATUS_ABNORMAL_TERMINATION);
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.AbnormalTermDuration",
+                              details.run_duration);
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.AbnormalTermKernelTime",
+                              details.kernel_duration);
+          UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.AbnormalTermUserTime",
+                              details.user_duration);
+        }
+      }
+#endif  // OS_WIN
+    }
+
+    // TODO(jar): These histograms should be small enumerated histograms.
     UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes",
                              was_extension_process ? 2 : 1);
-    if (was_alive) {
+    if (details.was_alive) {
       UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashesWasAlive",
                                was_extension_process ? 2 : 1);
     }
-  } else if (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
+  } else if (details.status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
     UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKills",
                              was_extension_process ? 2 : 1);
-    if (was_alive) {
+    if (details.was_alive) {
       UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKillsWasAlive",
                                was_extension_process ? 2 : 1);
     }
   }
+
+#if defined(OS_WIN)
+  if (details.have_process_times && !was_extension_process &&
+      details.status != base::TERMINATION_STATUS_PROCESS_CRASHED &&
+      details.status != base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
+    UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.NormalTermDuration",
+                        details.run_duration);
+    UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.NormalTermKernelTime",
+                        details.kernel_duration);
+    UMA_HISTOGRAM_TIMES("BrowserRenderProcessHost.NormalTermUserTime",
+                        details.user_duration);
+  }
+#endif  // OS_WIN
 }
 
 void MetricsService::LogRendererHang() {
   IncrementPrefValue(prefs::kStabilityRendererHangCount);
 }
 
 void MetricsService::LogNeedForCleanShutdown() {
   PrefService* pref = g_browser_process->local_state();
   pref->SetBoolean(prefs::kStabilityExitedCleanly, false);
   // Redundant setting to be sure we call for a clean shutdown.
@@ skipping 255 matching lines @@
   if (local_state) {
     const PrefService::Preference* uma_pref =
         local_state->FindPreference(prefs::kMetricsReportingEnabled);
     if (uma_pref) {
       bool success = uma_pref->GetValue()->GetAsBoolean(&result);
       DCHECK(success);
     }
   }
   return result;
 }