SPDY - Added enabling of SPDY/3 to about:flags.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 249 matching lines @@
   }
 
   if (parsed_command_line.HasSwitch(switches::kEnableWebSocketOverSpdy)) {
     // Enable WebSocket over SPDY.
     net::WebSocketJob::set_websocket_over_spdy_enabled(true);
   }
 
   if (parsed_command_line.HasSwitch(switches::kEnableHttpPipelining))
     net::HttpStreamFactory::set_http_pipelining_enabled(true);
 
+  if (parsed_command_line.HasSwitch(switches::kEnableSPDY3)) {

[willchan no longer on Chromium, 2012/03/21 16:15:32]

How does this command line flag interact with the --use-spdy flags? For example,
how does it interact with flow control?

[ramant (doing other things), 2012/03/21 18:46:36]

If --use-sdy=off, then enable-spdy3 is ignored.

Currently HttpStreamFactory::SetNextProtos is accumulating all next_protos. If
flow control is enabled and enable-spdy3 is enabled, then chrome supports
http/1.1, spdy/2, spdy/2.1 and spdy/3.

Would appreciate your opinion on if we should do something different.

thanks much.

[willchan no longer on Chromium, 2012/03/21 23:01:55]

What about --use-spdy=v3? or --use-spdy=flow-control?

+    std::vector<std::string> next_protos;
+    next_protos.push_back("http/1.1");
+    next_protos.push_back("spdy/2");
+    next_protos.push_back("spdy/2.1");
+    next_protos.push_back("spdy/3");
+    net::HttpStreamFactory::SetNextProtos(next_protos);
+  }
+
   if (parsed_command_line.HasSwitch(switches::kTestingFixedHttpPort)) {
     int value;
     base::StringToInt(
         parsed_command_line.GetSwitchValueASCII(
             switches::kTestingFixedHttpPort),
         &value);
     net::HttpStreamFactory::set_testing_fixed_http_port(value);
   }
 
   if (parsed_command_line.HasSwitch(switches::kTestingFixedHttpsPort)) {
@@ skipping 1663 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }