Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 9764009: Add median latency to my_reviews.py. Do more calculation on the fly. (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add median latency to my_reviews.py. Do more calculation on the fly. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127856

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M my_reviews.py View 1 2 4 chunks +39 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Adding the median is useful, for example I get these stats: Average latency from request ...
8 years, 9 months ago (2012-03-21 00:52:43 UTC) #1
Dirk Pranke
lgtm w/ one comment. https://chromiumcodereview.appspot.com/9764009/diff/4/my_reviews.py File my_reviews.py (right): https://chromiumcodereview.appspot.com/9764009/diff/4/my_reviews.py#newcode84 my_reviews.py:84: if length & 1: are ...
8 years, 9 months ago (2012-03-21 00:54:14 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/9764009/diff/4/my_reviews.py File my_reviews.py (right): https://chromiumcodereview.appspot.com/9764009/diff/4/my_reviews.py#newcode84 my_reviews.py:84: if length & 1: On 2012/03/21 00:54:14, Dirk Pranke ...
8 years, 9 months ago (2012-03-21 01:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9764009/1002
8 years, 9 months ago (2012-03-21 01:01:23 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 01:07:46 UTC) #5
Change committed as 127856

Powered by Google App Engine
This is Rietveld 408576698