Support custom drag-and-drop of bookmarks in Aura

chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.h"
 
 #include "base/event_types.h"
 #include "base/message_loop.h"
+#include "chrome/browser/tab_contents/web_drag_bookmark_handler_aura.h"
 #include "chrome/browser/ui/sad_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/ui/views/tab_contents/native_tab_contents_view_delegate.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "ui/aura/client/drag_drop_client.h"
 #include "ui/aura/client/drag_drop_delegate.h"
 #include "ui/aura/event.h"
@@ skipping 153 matching lines @@
   NOTIMPLEMENTED() << "Need to animate in";
 #endif
 
   // Hide the widget to prevent it from showing up on the root window. This is
   // needed for TabContentses that aren't immediately added to the tabstrip,
   // e.g. the Instant preview contents.
   // TODO(beng): investigate if control-type windows shouldn't be hidden by
   //             default if they are created with no parent. Pending oshima's
   //             change to reflect Widget types onto a ViewProp.
   GetWidget()->Hide();
+
+  bookmark_handler_.reset(new WebDragBookmarkHandlerAura());

[Ben Goodger (Google), 2012/03/20 17:25:54]

hrm. tying the bookmark stuff into here is going to make it harder to move this
into content. How is this done on Windows and why are we different?

[varunjain, 2012/03/20 18:19:16]

On other platforms, bookmark handling is hooked to WebDragDest{Win|Gtk|Mac}.
These listen to platform drag event directly and forward those events to the
renderer. On Aura, we get drag events here through the NativeWidgetAura, hence I
did not feel WebDragDestAura is necessary.

On other platforms NTCV{Gtk|Win} and WebDragBookmarkHandler{Gtk|Win} live in the
same chrome/browser hierarchy as here for NTCVAura and the newly added
WebDragBookmarkHandlerAura. So I am not sure how is it different for aura.

 }
 
 RenderWidgetHostView* NativeTabContentsViewAura::CreateRenderWidgetHostView(
     content::RenderWidgetHost* render_widget_host) {
   RenderWidgetHostView* view =
       RenderWidgetHostView::CreateViewForWidget(render_widget_host);
 
   view->InitAsChild(NULL);
   GetNativeView()->AddChild(view->GetNativeView());
   view->Show();
@@ skipping 94 matching lines @@
         // TODO(oshima): mouse wheel
         break;
     }
   }
   // Pass all mouse event to renderer.
   return views::NativeWidgetAura::OnMouseEvent(event);
 }
 
 void NativeTabContentsViewAura::OnDragEntered(
     const aura::DropTargetEvent& event) {
+  bookmark_handler_->DragInitialize(GetWebContents());
+
   WebDropData drop_data;
   PrepareWebDropData(&drop_data, event.data());
   WebKit::WebDragOperationsMask op = ConvertToWeb(event.source_operations());
 
   gfx::Point screen_pt =
       GetNativeView()->GetRootWindow()->last_mouse_location();
   GetWebContents()->GetRenderViewHost()->DragTargetDragEnter(
       drop_data, event.location(), screen_pt, op);
+
+  bookmark_handler_->OnDragEnter(event.data());
 }
 
 int NativeTabContentsViewAura::OnDragUpdated(
     const aura::DropTargetEvent& event) {
   WebKit::WebDragOperationsMask op = ConvertToWeb(event.source_operations());
   gfx::Point screen_pt =
       GetNativeView()->GetRootWindow()->last_mouse_location();
   GetWebContents()->GetRenderViewHost()->DragTargetDragOver(
       event.location(), screen_pt, op);
+
+  bookmark_handler_->OnDragOver();
+
   return ConvertFromWeb(current_drag_op_);
 }
 
 void NativeTabContentsViewAura::OnDragExited() {
   GetWebContents()->GetRenderViewHost()->DragTargetDragLeave();
+  bookmark_handler_->OnDragLeave();
 }
 
 int NativeTabContentsViewAura::OnPerformDrop(
     const aura::DropTargetEvent& event) {
   GetWebContents()->GetRenderViewHost()->DragTargetDrop(
       event.location(),
       GetNativeView()->GetRootWindow()->last_mouse_location());
+  bookmark_handler_->OnDrop();
   return current_drag_op_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTabContentsViewAura, private:
 
 void NativeTabContentsViewAura::EndDrag(WebKit::WebDragOperationsMask ops) {
   aura::RootWindow* root_window = GetNativeView()->GetRootWindow();
   gfx::Point screen_loc = root_window->last_mouse_location();
   gfx::Point client_loc = screen_loc;
   RenderViewHost* rvh = GetWebContents()->GetRenderViewHost();
   aura::Window* window = rvh->GetView()->GetNativeView();
   aura::Window::ConvertPointToWindow(root_window, window, &client_loc);
   rvh->DragSourceEndedAt(client_loc.x(), client_loc.y(), screen_loc.x(),
       screen_loc.y(), ops);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTabContentsView, public:
 
 // static
 NativeTabContentsView* NativeTabContentsView::CreateNativeTabContentsView(
     internal::NativeTabContentsViewDelegate* delegate) {
   return new NativeTabContentsViewAura(delegate);
 }